feat: add homework stats display - #148
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the homework statistics page to compute scoreboard data dynamically from submission records rather than using precomputed status maps. The change introduces more flexible submission filtering with time-based query parameters and removes the dependency on the dayjs library.
- Adds
after,before, andip_prefixquery parameters to the submission list API - Implements client-side scoreboard computation by aggregating all submissions per user and problem
- Adds a new (but unused)
getScoreboardAPI method
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| src/types/submission.d.ts | Adds new query parameters (after, before, ip_prefix) for time-based and IP-based submission filtering |
| src/types/scoreboard.d.ts | Modifies problems field to support both Record and array types for flexibility |
| src/api/homework.ts | Introduces getScoreboard API method (currently unused in the codebase) |
| src/pages/courses/[courseId]/homeworks/[id]/stats.vue | Major refactor: removes dayjs dependency, implements paginated submission fetching, computes scoreboard client-side from raw submissions, and simplifies template formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the homework statistics page to compute the scoreboard directly from submission data rather than relying on precomputed status maps. It introduces a new API method for fetching the scoreboard, rewrites the logic for aggregating and ranking submissions, and improves the clarity and maintainability of the statistics code.
API changes:
getScoreboardmethod to thehomeworkAPI, which retrieves the scoreboard data for a specific homework assignment.Scoreboard computation and data handling:
Refactored the scoreboard logic in
stats.vueto aggregate submission data per user and problem, determining scores, statuses, and timestamps directly from submissions rather than a precomputed status map. This includes:Code and UI simplification:
Simplified the code by removing the unused
dayjsimport and cleaning up the submissions fetching logic and related computed properties.Made minor formatting improvements to the scoreboard table and chart section for better readability and maintainability.