Use VDS to get drive info #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es anyway, we can simplify the logic.
…n VDS method. If VDS fails, use old method as backup.
…ting DeviceId (Name) from WMI
Collaborator
|
I'm going to test this out on my system at home with multiple drives just to give it a proper test then merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes source of drives info from WMI to VDS (Virtual Disk Service), same source that Disk Manager app uses.
Benefits are following:
Disk layout is now divided into extents (
A contiguous set of one or more disk sectors), which now can show hidden disk areas containing partition table, MSR partitions, etc.WMI is still used to get drive PnP ID. In case VDS service fails to load, WMI method is used as fallback.