Open
Conversation
This change allows the `tnoodle draw` command to read a scramble string
from standard input if the `-s` or `--scramble` parameter is not explicitly
provided. This enables piping the output of `tnoodle scramble` directly to
`tnoodle draw`.
Key changes:
- Modified `DrawCommand.java` to make the `scramble` parameter optional and
to read from `System.in` if the scramble is not given as an argument.
- Added robust error handling for cases such as empty stdin or invalid
scramble input.
- Introduced `DrawCommandTest.java` with unit tests:
- `testDrawCommand_readsFromStdin`: Verifies reading a scramble directly
from stdin.
- `testFullPipeWorkflow_scrambleToDraw`: Verifies the complete workflow of
piping `tnoodle scramble` output to `tnoodle draw`.
- Updated `README.md` to document the new piping feature with an example:
`tnoodle scramble -p three | tnoodle draw -p three > output.svg`.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the
tnoodle drawcommand to read a scramble string from standard input if the-sor--scrambleparameter is not explicitly provided. This enables piping the output oftnoodle scrambledirectly totnoodle draw.Key changes:
DrawCommand.javato make thescrambleparameter optional and to read fromSystem.inif the scramble is not given as an argument.DrawCommandTest.javawith unit tests:testDrawCommand_readsFromStdin: Verifies reading a scramble directly from stdin.testFullPipeWorkflow_scrambleToDraw: Verifies the complete workflow of pipingtnoodle scrambleoutput totnoodle draw.README.mdto document the new piping feature with an example:tnoodle scramble -p three | tnoodle draw -p three > output.svg.