Renaming the flogger package and the backing classes#98
Merged
alexander-yevsyukov merged 31 commits intomasterfrom Jun 26, 2025
Merged
Renaming the flogger package and the backing classes#98alexander-yevsyukov merged 31 commits intomasterfrom
flogger package and the backing classes#98alexander-yevsyukov merged 31 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=========================================
Coverage ? 59.57%
Complexity ? 795
=========================================
Files ? 116
Lines ? 3871
Branches ? 506
=========================================
Hits ? 2306
Misses ? 1364
Partials ? 201 🚀 New features to boost your workflow:
|
flogger package and logging impl. backing classes
…yout-and-punctuation Fix Javadoc formatting
…t-in-io.spine.logging.jvm Fix Javadoc layout
The name suggests further merging in with the `Api` in the `logging` package.
flogger package and logging impl. backing classesflogger package and the backing classes
…er.-to-.jvm # Conflicts: # AGENTS.md # flogger/middleware/src/main/java/io/spine/logging/flogger/backend/Platform.java
armiol
requested changes
Jun 26, 2025
Contributor
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov see my comments so far. 86 / 297 reviewed.
Also: * Improve the documentation. * Restore (c) headers.
armiol
approved these changes
Jun 26, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the "flogger" package and related classes to "jvm" while updating copyright years and comments to reflect the new naming.
- Package renaming in context, backend, parser, and API classes
- Renaming of logger API interfaces (e.g. FloggerApi to MiddlemanApi) and updating associated references
- Adjusted copyright notices and documentation comments for historical context
Reviewed Changes
Copilot reviewed 131 out of 300 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| jvm/middleware/src/main/java/io/spine/logging/jvm/context/ContextDataProvider.java | Updated package name from "flogger.context" to "jvm.context" and corresponding imports and comments. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/package-info.java | Updated package name in package-info and updated copyright notice. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/TemplateContext.java | Changed package and import references accordingly. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/SimpleMessageFormatter.java | Added new file with proper copyright and package updates. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/Platform.java | Updated package name; adjusted documentation comments. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/MetadataProcessor.java | Added new file with proper refactoring from "flogger" to "jvm". |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/MetadataKeyValueHandlers.java | Package and copyright updates. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/MetadataHandler.java | Updated package declaration and documentation references. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/Metadata.java | Renamed package references inside to "jvm.backend" and updated links. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/MessageUtils.java | Updated package references and links for historical context. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/LoggingException.java | Package and copyright changes. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/LoggerBackend.java | Updated package and documentation references; reformatted code comments. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/LogMessageFormatter.java | Updated package and documentation links. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/LogData.java | Added new file with package and copyright changes. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/KeyValueFormatter.java | New file with package and refactored formatting comments. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/FormatType.java | Renamed and updated package and documentation references. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/FormatOptions.java | New file with package and copyright updates. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/FormatChar.java | New file with package and refactored API for format characters. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/Clock.java | Package renaming in clock API. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/BaseMessageFormatter.java | New file with package renaming and updated formatting logic. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/backend/BackendFactory.java | Package renaming in backend factory API. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/StackSize.java | Package renaming and updated documentation. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/StackBasedLogSite.java | Renamed parent class from FloggerLogSite to JvmLogSite and updated package references. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/SpecializedLogSiteKey.java | Package and documentation updates. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/SamplingRateLimiter.java | New file with package renaming and rate limiting logic. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/RateLimitStatus.java | New file with package and documentation updates regarding rate limit operations. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/MiddlemanApi.java | Renamed logging API interface from FloggerApi to MiddlemanApi and updated method signatures accordingly. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/Middleman.java | Renamed logger implementation from FluentLogger2 to Middleman and updated API references. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/MetadataKey.java | Renamed FloggerMetadataKey to MetadataKey and updated utility imports and documentation. |
| jvm/middleware/src/main/java/io/spine/logging/jvm/LoggingScopeProvider.java | Package renaming in scope provider with updated documentation references. |
Files not reviewed (2)
- .idea/inspectionProfiles/Project_Default.xml: Language not supported
- .idea/kotlinc.xml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
floggerpackage and directories tojvm. Also the classes starting fromFloggerorFluentwere renamed.The
MiddlemannameThe name was selected as a temporary measure.
It hints on the plan that these classes or interfaces will be merged in with those having similar responsibilities in the
jvmMainsource set of theloggingmodule.This is planned for the one of the following PRs this or next week.
Next steps
middlewareto Kotlin.middlewarepackage intojvmMainsource set of theloggingmodule.