Remove Rule-related classes#219
Merged
yevhenii-nadtochii merged 10 commits intomasterfrom May 2, 2025
Merged
Conversation
added 8 commits
April 30, 2025 11:01
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
============================================
+ Coverage 28.21% 32.65% +4.44%
+ Complexity 242 236 -6
============================================
Files 138 119 -19
Lines 3314 2811 -503
Branches 247 205 -42
============================================
- Hits 935 918 -17
+ Misses 2327 1841 -486
Partials 52 52 🚀 New features to boost your workflow:
|
Contributor
Author
armiol
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a cleanup by removing
Rule-related classes previously used as intermediate representation of validation logic.The removed entities are the following:
SimpleRule,CompositeRule, their events and related Proto messages.RuleGenerator,CodeGenerator,GenerationContext, custom generators.Rule-specificErrorMessageandTemplate.CompilationMessagethat used to accumulate rules per message type.FieldTypeExts– they have already been moved to ProtoData.MakeFilterHappyTest– they are no longer needed. config #421 is actually resolved.The implementation of
ValidatableMessage.validate()has also been removed from the generated code. Now, the generated code should rely on the default implementation provided by the interface.Module dependencies of
:javahave also been cleaned up. We no longer needRoasterandJavaPoetthere.Validation extension tests are temporarily disabled until #215 is ready.