Conversation
There was a problem hiding this comment.
Pull request overview
Updates documentation embed-code configuration and example references while bumping project/dependency versions and the Gradle wrapper.
Changes:
- Bump Validation snapshot versions across Gradle/Maven metadata and generated dependency report.
- Update docs to embed code from the examples directory via a named
$examplespath. - Upgrade Gradle wrapper distribution URL (and related wrapper script reference).
Reviewed changes
Copilot reviewed 14 out of 21 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Bumps the validationVersion extra property snapshot. |
| pom.xml | Bumps Maven project version and updates select dependency versions. |
| gradlew | Updates the referenced Gradle template URL to a pinned commit. |
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle distribution URL to 9.4.0. |
| docs/content/docs/validation/01-getting-started/generated-code.md | Switches embed-code file attributes to use $examples/... paths and multiline tags. |
| docs/content/docs/validation/01-getting-started/first-model.md | Updates embedded proto sample reference to $examples/.... |
| docs/content/docs/validation/01-getting-started/adding-to-build.md | Updates embedded build/settings samples to use $examples/.... |
| docs/_settings/embed-code.yml | Introduces named code roots (examples, production) and expands embed mappings. |
| docs/_examples | Updates the examples submodule commit. |
| dependencies.md | Regenerates dependency/license report for the new snapshot. |
| config | Updates the config submodule commit. |
| buildSrc/src/main/kotlin/io/spine/gradle/testing/Logging.kt | Removes no-op TestListener method overrides. |
| buildSrc/src/main/kotlin/io/spine/gradle/kotlin/KotlinConfig.kt | Reorders imports (moves JvmDefaultMode). |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt | Bumps local Validation version constant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 25 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jvm-runtime/src/main/kotlin/io/spine/validation/MessageValidator.kt
Outdated
Show resolved
Hide resolved
jvm-runtime/src/main/kotlin/io/spine/validation/MessageValidator.kt
Outdated
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/SpineEventEngine/validation/blob/a381e69bb30871e7bc60c1b20de71755721d6366/docs/_bin/embed-code-linux#L1
This update replaces docs/_bin/embed-code-ubuntu with docs/_bin/embed-code-linux, but docs/_script/check-samples (called by .github/workflows/check-code-embedding.yml in the :docs:checkSamples job on ubuntu-latest) still runs ./embed-code-ubuntu when GITHUB_ACTIONS=true. In that environment the command now fails with No such file or directory, so the code-embedding check job will fail consistently until the binary name or caller is aligned.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 25 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR applies latest binaries of
embed-code-gowhich allowed to use multiple code roots. The code snippet ofTimestampValidatornow uses the embedding of from thejvm-runtimemodule.Also, the description of
MessageValidatorinterface was updated to match the recent changes in the behavior of validators.