Apply new publishing by alexander-yevsyukov · Pull Request #286 · SpineEventEngine/validation

alexander-yevsyukov · 2026-04-03T17:15:17Z

This PR brings changes to SpinePublishing through pulling latest config.

Other notable changes

Addressed dependency bump reported by Dependabot.

Bumps and [picomatch](https://github.com/micromatch/picomatch). These dependencies needed to be updated together. Updates `picomatch` from 2.3.1 to 2.3.2 - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@2.3.1...2.3.2) Updates `picomatch` from 4.0.3 to 4.0.4 - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@2.3.1...2.3.2) --- updated-dependencies: - dependency-name: picomatch dependency-version: 2.3.2 dependency-type: indirect - dependency-name: picomatch dependency-version: 4.0.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…eview/multi-bf05dc1ecf' into new-publishing

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c12e182b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-03T17:20:10Z

buildSrc/src/main/kotlin/io/spine/gradle/publish/SpinePublishing.kt

+     *
+     * @see artifactPrefix
+     */
+    var toolArtifactPrefix: String = ""


Apply toolArtifactPrefix when computing published artifact IDs

This adds toolArtifactPrefix, but the publication path still ignores it: PublicationHandler.copyProjectAttributes() continues to prepend project.spinePublishing.artifactPrefix for every module, and nothing calls SpinePublishing.artifactId(project). In a mixed project, tool modules (group == io.spine.tools) will still be published as spine-validation-* even when toolArtifactPrefix = "validation-", which breaks expected coordinates (for example, pom.xml still references io.spine.tools:validation-java-bundle).

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-03T17:20:10Z

build.gradle.kts

 }

 spinePublishing {
+    artifactPrefix = "spine-validation-"


Avoid double spine prefix for jvm-runtime publication

Setting the root artifactPrefix to spine-validation- causes jvm-runtime to generate a doubled artifact ID because jvm-runtime/build.gradle.kts already does artifactId = "$defaultPrefix$projectPrefix${project.name}" with defaultPrefix = "spine-"; this now resolves to spine-spine-validation-jvm-runtime. That will publish runtime under an unexpected coordinate and break consumers expecting spine-validation-jvm-runtime.

Useful? React with 👍 / 👎.

Copilot

Pull request overview

Updates the project’s publishing configuration (via SpinePublishing) and refreshes dependency/version coordinates, including a Dependabot-reported picomatch bump for the docs preview.

Changes:

Adjust SpinePublishing API/behavior to support separate artifact prefixes for tool vs non-tool modules and return the configured extension instance.
Bump project and related Spine dependency versions; update docs/snippets and generated dependency report accordingly.
Update test tooling/dependencies (Kotest assertions usage, buildSrc test deps) and patch plugin-version update regex handling.

Reviewed changes

Copilot reviewed 17 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
version.gradle.kts	Bumps the overall project version.
pom.xml	Updates Maven project/dependency versions (incl. Kotest).
build.gradle.kts	Configures new `SpinePublishing` prefixes for tool publishing.
java-bundle/build.gradle.kts	Aligns Time artifact constant usage with updated `Time` dependency model.
docs/content/docs/validation/01-getting-started/adding-to-build.md	Updates plugin version in documentation snippet.
docs/_preview/package-lock.json	Bumps `picomatch` versions per Dependabot/security update.
dependencies.md	Regenerates dependency/license report for the new versions.
buildSrc/build.gradle.kts	Updates buildSrc test dependencies (JUnit BOM via version var; adds Kotest assertions).
buildSrc/src/main/kotlin/io/spine/gradle/publish/SpinePublishing.kt	Implements tool/non-tool artifact prefixing and adjusts extension naming/return value.
buildSrc/src/test/kotlin/io/spine/gradle/publish/SpinePublishingTest.kt	Adds tests covering `SpinePublishing` artifactId/config validation/repo resolution logic.
buildSrc/src/main/kotlin/io/spine/gradle/docs/UpdatePluginVersion.kt	Escapes plugin IDs in regex to avoid regex metacharacter issues.
buildSrc/src/test/kotlin/io/spine/gradle/docs/UpdatePluginVersionTest.kt	Switches assertions to Kotest matchers and adds display name.
buildSrc/src/main/kotlin/io/spine/dependency/test/Kotest.kt	Bumps Kotest version constant.
buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt	Bumps local Validation dependency version constant.
buildSrc/src/main/kotlin/io/spine/dependency/local/ToolBase.kt	Bumps ToolBase versions.
buildSrc/src/main/kotlin/io/spine/dependency/local/Base.kt	Bumps Base versions.
buildSrc/src/main/kotlin/io/spine/dependency/local/Time.kt	Refactors `Time` into `Dependency()`-based model and bumps version.

Files not reviewed (1)

docs/_preview/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-03T17:20:23Z

buildSrc/src/main/kotlin/io/spine/gradle/publish/SpinePublishing.kt

+fun Project.spinePublishing(block: SpinePublishing.() -> Unit): SpinePublishing {
    apply<MavenPublishPlugin>()
    val name = SpinePublishing::class.java.simpleName
+        .replaceFirstChar { it.lowercase(Locale.getDefault()) }


Using Locale.getDefault() when deriving the Gradle extension name can produce different names on machines with different default locales (e.g., Turkish locale casing), which may break Kotlin DSL accessors and reduce build reproducibility. Consider using a locale-invariant option such as Locale.ROOT when lowercasing the first character.

Suggested change

.replaceFirstChar { it.lowercase(Locale.getDefault()) }

.replaceFirstChar { it.lowercase(Locale.ROOT) }

Copilot · 2026-04-03T17:20:23Z

buildSrc/src/main/kotlin/io/spine/dependency/local/Time.kt

+    fun kotlinExtensions(version: String): String = "$group:$infix-kotlin:$version"
+    val kotlinExtensions get() = kotlinExtensions(version)
+
+    fun testLib(version: String): String = "${Spine.toolsGroup}:time-testlib:$version"


testLib() uses the artifact time-testlib, which is inconsistent with the infix (spine-time) and with the established naming pattern for other *-testlib artifacts in this repo (e.g. spine-logging-testlib, spine-core-testlib). This looks like a wrong Maven coordinate and may lead to unresolved dependencies; consider deriving it from infix (e.g. spine-time-testlib) to keep it consistent.

Suggested change

fun testLib(version: String): String = "${Spine.toolsGroup}:time-testlib:$version"

fun testLib(version: String): String = "${Spine.toolsGroup}:${infix}-testlib:$version"

Copilot · 2026-04-03T17:20:23Z

buildSrc/src/test/kotlin/io/spine/gradle/publish/SpinePublishingTest.kt

+            // Subproject's extension must be named 'SpinePublishing' 
+            // to be found by SpinePublishing::class.java.simpleName
+            val extensionName = SpinePublishing::class.java.simpleName
+            val subExtension = subproject.extensions.create<SpinePublishing>(extensionName, subproject)


These comments about the subproject extension needing to be named SpinePublishing to be found by SpinePublishing::class.java.simpleName appear incorrect/misleading: the production code looks up the extension by type (findByType<SpinePublishing>()), not by name. Consider updating/removing this note to avoid confusion (and note that spinePublishing() now lowercases the extension name).

Suggested change

// Subproject's extension must be named 'SpinePublishing'

// to be found by SpinePublishing::class.java.simpleName

val extensionName = SpinePublishing::class.java.simpleName

val subExtension = subproject.extensions.create<SpinePublishing>(extensionName, subproject)

// Use the conventional extension name used by the plugin.

val subExtension = subproject.extensions.create<SpinePublishing>("spinePublishing", subproject)

dependabot bot and others added 8 commits March 26, 2026 00:11

Bump version -> 2.0.0-SNAPSHOT.410

58866ed

Update config and local dependencies

86cba79

Update dependency reports

4787e27

Update version in examples

15d1a84

Update version in examples

421d98c

Escape plugin ID in regex

1dc11f8

Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/docs/_pr…

3c12e18

…eview/multi-bf05dc1ecf' into new-publishing

Copilot AI review requested due to automatic review settings April 3, 2026 17:15

alexander-yevsyukov mentioned this pull request Apr 3, 2026

Bump picomatch in /docs/_preview #284

Closed

alexander-yevsyukov marked this pull request as ready for review April 3, 2026 17:15

alexander-yevsyukov self-assigned this Apr 3, 2026

Copilot started reviewing on behalf of alexander-yevsyukov April 3, 2026 17:15 View session

alexander-yevsyukov enabled auto-merge April 3, 2026 17:17

alexander-yevsyukov requested a review from armiol April 3, 2026 17:17

chatgpt-codex-connector bot reviewed Apr 3, 2026

View reviewed changes

Copilot AI reviewed Apr 3, 2026

View reviewed changes

armiol approved these changes Apr 3, 2026

View reviewed changes

alexander-yevsyukov merged commit e31db6a into master Apr 3, 2026
11 of 12 checks passed

alexander-yevsyukov deleted the new-publishing branch April 3, 2026 17:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply new publishing#286

Apply new publishing#286
alexander-yevsyukov merged 8 commits intomasterfrom
new-publishing

alexander-yevsyukov commented Apr 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Apr 3, 2026

Uh oh!

chatgpt-codex-connector bot Apr 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	.replaceFirstChar { it.lowercase(Locale.getDefault()) }
	.replaceFirstChar { it.lowercase(Locale.ROOT) }

	fun testLib(version: String): String = "${Spine.toolsGroup}:time-testlib:$version"
	fun testLib(version: String): String = "${Spine.toolsGroup}:${infix}-testlib:$version"

Conversation

alexander-yevsyukov commented Apr 3, 2026

Other notable changes

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants