🔧 Settings: 수원 체육시설 및 매칭 더미 데이터 SQL 추가#70
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Walkthrough.github 이슈 템플릿 추가, Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 시
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
data/suwon_facilities_and_matches.sql (1)
1-3: SQL 문 대소문자 일관성 유지 필요Line 1의
delete는 소문자이고, Lines 2-3의DELETE는 대문자입니다. 일관성을 위해 모두 대문자로 통일하는 것이 좋습니다.💅 수정 제안
-delete from match_participants; +DELETE FROM match_participants; DELETE FROM match_rooms; DELETE FROM sports_facilities;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@data/suwon_facilities_and_matches.sql` around lines 1 - 3, Normalize SQL keyword casing by changing the lowercase "delete" to uppercase "DELETE" to match the other statements; update the statement affecting table match_participants so all three DDL/DML statements use "DELETE" (reference: the existing statements operating on match_participants, match_rooms, and sports_facilities).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/ISSUE_TEMPLATE/🔧 -settings.md:
- Around line 1-12: The file .github/ISSUE_TEMPLATE/🔧 -settings.md has a
mismatch between its filename and the frontmatter/template content (the
frontmatter currently defines a Documentation issue template), so either rename
the file to match the template (e.g., 📝-docs.md without the space before the
hyphen) or update the YAML frontmatter (name, about, title, labels) and the
template body to reflect a Settings issue; also remove the space between the
emoji and the hyphen in the filename to avoid tooling issues and ensure the
frontmatter keys (name, about, title) correctly describe "Settings" if you
choose to keep the current filename.
In `@data/suwon_facilities_and_matches.sql`:
- Around line 369-379: The INSERT block in data/suwon_facilities_and_matches.sql
is using hardcoded facility_id values (e.g., 35, 36, 37) which will break if
sequences change; update the script to either (A) ensure the target tables are
truncated with sequence reset before inserts (use TRUNCATE ... RESTART IDENTITY
CASCADE for the facilities/matches tables) or (B) replace the numeric
facility_id literals in the VALUES tuples with a subquery that looks up the id
by facility name (e.g., (SELECT id FROM facilities WHERE name = '...')) so the
INSERTs reference facility_name rather than fixed IDs; apply this change to all
tuples in the SOCCER block so they won't rely on specific sequence values.
---
Nitpick comments:
In `@data/suwon_facilities_and_matches.sql`:
- Around line 1-3: Normalize SQL keyword casing by changing the lowercase
"delete" to uppercase "DELETE" to match the other statements; update the
statement affecting table match_participants so all three DDL/DML statements use
"DELETE" (reference: the existing statements operating on match_participants,
match_rooms, and sports_facilities).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 63c4c122-55ec-49ea-a4b2-67b10794972d
⛔ Files ignored due to path filters (1)
data/경기도_수원시_공공체육시설현황_20240826.csvis excluded by!**/*.csv
📒 Files selected for processing (3)
.github/ISSUE_TEMPLATE/🔧 -settings.mdCLAUDE.mddata/suwon_facilities_and_matches.sql
Comment on lines
+1
to
+12
| --- | ||
| name: "\U0001F4DD Documentation" | ||
| about: 문서 수정 이슈 템플릿 | ||
| title: "\U0001F4DDDocs: " | ||
| labels: "\U0001F4C3 Docs" | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| ## 📌 Description | ||
| - | ||
| - |
There was a problem hiding this comment.
파일명과 템플릿 내용 불일치
파일명은 🔧 -settings.md (Settings)인데, 템플릿 내용은 📝 Documentation (문서 수정)용입니다. 의도에 맞게 파일명을 📝-docs.md로 변경하거나, Settings 이슈 템플릿 내용으로 수정해야 합니다.
또한 파일명에 이모지와 하이픈 사이에 공백이 있어 일부 시스템에서 문제가 될 수 있습니다.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/ISSUE_TEMPLATE/🔧 -settings.md around lines 1 - 12, The file
.github/ISSUE_TEMPLATE/🔧 -settings.md has a mismatch between its filename and
the frontmatter/template content (the frontmatter currently defines a
Documentation issue template), so either rename the file to match the template
(e.g., 📝-docs.md without the space before the hyphen) or update the YAML
frontmatter (name, about, title, labels) and the template body to reflect a
Settings issue; also remove the space between the emoji and the hyphen in the
filename to avoid tooling issues and ensure the frontmatter keys (name, about,
title) correctly describe "Settings" if you choose to keep the current filename.
Comment on lines
+369
to
+379
| -- SOCCER 35~42 | ||
| ('SOCCER', 35, 0, 10, 'OPEN', 60, 3000, NOW() + interval '2 days', 'BRING_OWN', 2, false, NOW(), NOW()), | ||
| ('SOCCER', 35, 0, 10, 'OPEN', 90, 3000, NOW() + interval '5 days', 'VEST_PROVIDED', 2, true, NOW(), NOW()), | ||
| ('SOCCER', 36, 0, 8, 'OPEN', 60, 0, NOW() + interval '1 days', 'BRING_OWN', 2, false, NOW(), NOW()), | ||
| ('SOCCER', 36, 0, 8, 'OPEN', 60, 0, NOW() + interval '4 days', 'BRING_OWN', 2, true, NOW(), NOW()), | ||
| ('SOCCER', 37, 0, 8, 'OPEN', 60, 0, NOW() + interval '3 days', 'BRING_OWN', 2, false, NOW(), NOW()), | ||
| ('SOCCER', 38, 0, 8, 'OPEN', 60, 0, NOW() + interval '2 days', 'BRING_OWN', 2, true, NOW(), NOW()), | ||
| ('SOCCER', 39, 0, 10, 'OPEN', 60, 0, NOW() + interval '1 days', 'BRING_OWN', 2, false, NOW(), NOW()), | ||
| ('SOCCER', 40, 0, 8, 'OPEN', 60, 0, NOW() + interval '3 days', 'BRING_OWN', 2, false, NOW(), NOW()), | ||
| ('SOCCER', 41, 0, 8, 'OPEN', 60, 2000, NOW() + interval '4 days', 'BRING_OWN', 2, true, NOW(), NOW()), | ||
| ('SOCCER', 42, 0, 10, 'OPEN', 60, 2000, NOW() + interval '2 days', 'BRING_OWN', 2, false, NOW(), NOW()), |
There was a problem hiding this comment.
하드코딩된 facility_id 값은 취약한 참조 방식입니다
facility_id로 35, 36, 37 등 고정 값을 사용하고 있습니다. PostgreSQL에서 DELETE는 시퀀스를 리셋하지 않으므로, 스크립트 재실행 시 ID가 예상과 달라질 수 있습니다.
안전한 방법:
TRUNCATE ... RESTART IDENTITY CASCADE를 사용하여 시퀀스 리셋- 또는 서브쿼리로
facility_name기반 조회
🔧 시퀀스 리셋 방식 예시
-delete from match_participants;
-DELETE FROM match_rooms;
-DELETE FROM sports_facilities;
+TRUNCATE match_participants, match_rooms, sports_facilities RESTART IDENTITY CASCADE;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@data/suwon_facilities_and_matches.sql` around lines 369 - 379, The INSERT
block in data/suwon_facilities_and_matches.sql is using hardcoded facility_id
values (e.g., 35, 36, 37) which will break if sequences change; update the
script to either (A) ensure the target tables are truncated with sequence reset
before inserts (use TRUNCATE ... RESTART IDENTITY CASCADE for the
facilities/matches tables) or (B) replace the numeric facility_id literals in
the VALUES tuples with a subquery that looks up the id by facility name (e.g.,
(SELECT id FROM facilities WHERE name = '...')) so the INSERTs reference
facility_name rather than fixed IDs; apply this change to all tuples in the
SOCCER block so they won't rely on specific sequence values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
📝 요약(Summary)
🛠️ PR 유형
어떤 변경 사항이 있나요?
📸스크린샷 (선택)
💬 공유사항 to 리뷰어
중요 !!!!!!!!!!
시퀀스 값이 달라져서 id 값이 너랑 나랑 다를 수도 있으니까 꼭 기존 데이터들 비워주고 실행하기
그냥 내가 작성한 SQL 문 차례대로 실행하면 됨
꼭 sql 문 상단에
✅ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
Summary by CodeRabbit
릴리스 노트
Documentation
Chores