Spr 939 test runner improvement#590
Conversation
Usage:
./merge_system_settings.py <base_file> <override_file> <output_file>
…improvement feat: Settings overriding script
…il-inc/springtail into SPR-939-test-runner-improvement
SPR-939 Test runner: fixup runtime options
Right now you can run the test runner using the following options: <test_case_name> : run that test case and its overlays -o : overlay and all test cases using that overlay — I believe — (may be combined with test_case_name) : run default test cases and their overlays Right now: Running with no default runs the default set and EVERYTHING in the overlays even if the overlay specifies different test_cases. The only way to have a test that depends on an overlay is to set a flag in the overlay section, but this test case can't be run in the defaults since it won't apply the overlay. Need to clean it up; the code in test_runner.py is convoluted. There should be a way to specify a test_case requires an overlay. |
curiosthoth
left a comment
curiosthoth
left a comment
There was a problem hiding this comment.
Changes look good for the CI part.
craigsoules
left a comment
craigsoules
left a comment
There was a problem hiding this comment.
One very minor comment. Will let Garth do the approval.
| def skip(self) -> bool: | ||
| return self._skip | ||
|
|
There was a problem hiding this comment.
It doesn't look like you actually need this, so I'd remove it.
There was a problem hiding this comment.
This function is used by the test_runner.py.
garthgoodson
left a comment
garthgoodson
left a comment
There was a problem hiding this comment.
Couple of questions
|
5 participants
The code is ready for review. There is a failure in github CI workflow that is not related to the changes in the test framework. I am in the process of verifying the nightly build as well.