Redesign/homepage and pro v2 - #1
Merged
Merged
Conversation
The docstring said "19 built-in validators" while runBuiltInRule dispatches 27 cases. The marketing claim of 27 was right and the source comment was stale, not the other way round — verified by counting the switch cases. Also corrects the root README's test count. It read 1,151 from "824 core + 271 react + 56 adapters", which both used a pre-fix react number and omitted the templates suite entirely. Counted from a full run: 824 core + 288 react + 56 adapters + 102 templates = 1,270 Docstring only; no runtime change. 824 core tests still pass.
…sign system
The homepage read as a portfolio piece — "A side project · early", "I built
it to learn how to publish npm packages" — which told a buyer the project
would be abandoned. The product out-specs that framing, so the page now
leads with the one claim competitors structurally cannot make: responses go
from the browser to infrastructure the customer controls, with no vendor in
the path.
Section order now carries the argument: claim (Hero) → why it is structural
(DataFlow) → how to verify it (TrustStrip) → capability → paid tier →
limits. The founder narrative moved to /about rather than being deleted;
Scope stays on the homepage because it is what makes the rest credible.
Design system (components/homepage/v2.css + globals.css):
- engraved-plate depth tokens: --plate, --lit, --e1/e2/e3, --inset
- one section heading scale, replacing fixed 38px in 7 sections, a
26-36px clamp in 3, and one 44px — none of which scaled on mobile
- one vertical rhythm, replacing py-19/20/22 plus breakpoint overrides
- alternating grounds; 11 of 12 sections had sat on the same white, so
the middle of the page read as one undifferentiated field
- three CTA tiers consolidated from four divergent button systems
Numbers corrected across every surface (Rule 1). "44 field types" appeared
on 7 surfaces including layout metadata and the OpenGraph image; the
registry has 41. Test count was 1,151 in three places; a full run gives
1,270.
Two false claims removed after checking source: TrustStrip advertised
"row-level security and audit logging built into the adapter layer" —
neither exists, only AES-256-GCM encryption does; and a demo carried a
fabricated testimonial naming a real company.
LiveDemos: 41 dead CSS classes removed (297 lines) — hand-built card,
input, stepper and validation styles left over from when those demos were
mockups rather than real FormEngineRenderer instances.
ScrollReveal now drops its transform on transitionend. A lingering
transform — even translate-y-0 — makes an element a containing block for
position:fixed descendants, which offset dnd-kit's DragOverlay from the
cursor in the embedded Pro builder.
The Pro page predated the v2 design system entirely — zero plates, zero
elevation — and kept a parallel set of primitives: a fixed 34px heading
with its own breakpoint overrides, its own py-20 rhythm, muted eyebrows
with dots rather than the fading rule. All nine sections use shared.css,
so correcting that file moved the page at once.
Token ownership fixed: --fc-h2, --fc-section-y, --ground-2 and friends had
been declared in homepage/v2.css, which this page does not import. They are
site-wide, so they moved to globals.css.
Re-indexed (robots noindex removed) with the purchase CTA as a
non-clickable "Coming soon" plate, and deliberately NO Product/Offer
structured data — advertising a price and InStock to search engines for
something that cannot be bought would be false.
Rule 9 fixes found on the page:
- "Launch price — limited time" with a struck-through $399: an expiring
discount on an unpurchasable product
- "$199 once" in the hero eyebrow, away from any statement of
availability
Deleted two dead components. ProFaq claimed a "14-day refund, no questions
asked" policy contradicting the live FAQ's "all sales are final"; it was
rendered nowhere, so the wrong policy could have been reintroduced by
anyone who wired it up. ProContact was superseded by ProContactFaq.
Telehealth section rendered for the first time, after the feature grid
rather than inside it — that grid is headed "{n} features, one licence"
and computes the count from its own arrays, so folding a separate $99
add-on in would inflate Pro's feature count. Four claims corrected against
packages/telehealth: it is not "included with every Pro licence"; PSS-10
does not exist; templates are 7 not 14; field types are 8.
Two bugs fixed here that were first seen on the homepage builder:
--background must be the lit surface for Pro's segmented view-mode tabs to
show an active state, and overflow-hidden clips dnd-kit's non-portaled
DragOverlay.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.