ci: stop hiding the preview base marker from its own artifact - #212
Merged
Atharva0506 merged 1 commit intoSep 4, 2026
Merged
Conversation
actions/upload-artifact leaves hidden files out of the artifact unless told otherwise, so dist/.preview-base never reached the publish job: the artifact built for StabilityNexus#211 has 231 entries and not one dot-prefixed among them. The base check would then have read nothing, called it '<unset>', and refused every preview. Renamed rather than switched on include-hidden-files, so it does not depend on that input existing at the pinned action version.
Contributor
|
Warning Review limit reachedNext included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed Issues:
Follow-up to #211 — one line that PR needed and did not have when it merged. Previews cannot publish without it.
Description of Changes:
actions/upload-artifactleaves hidden files out of the artifact unlessinclude-hidden-filessays otherwise, sodist/.preview-basenever reached the publish job. Proof from #211's own build, artifact9947008574:The publish job reads that file to check the build was made for the path this site actually serves. With the file gone it reads nothing, reports
built '<unset>', and refuses to publish — so on currentmainevery preview fails the guard.Renamed to
dist/preview-baserather than switching oninclude-hidden-files, so it does not depend on that input existing at the pinned action version. The publish job still deletes it before committing, so it is never served.Verification
Guard exercised locally against a scratch bare repo in all three states:
/Chainvoice/...against a/site → rejected, naming the value to set/pr-preview/pr-209/against a/site → passes, marker consumed before publishing<unset>, which is whatmaindoes todayAI Usage Disclosure:
I used Claude Code to find this by inspecting the artifact zip produced by #211's build, and to verify the fix.
Checklist