feat: add pre-hydration theme bootstrapping#33
Closed
xx7412421-cloud wants to merge 5 commits into
Closed
Conversation
Documents the pre-hydration theme script approach for StableRoute-Org#27.
Injects the theme initialization script before paint for StableRoute-Org#27.
Exports the theme storage key so the pre-hydration script can use the same preference key for StableRoute-Org#27.
Adds a tiny dependency-free theme initialization script builder for StableRoute-Org#27.
Covers stored light/dark/system preferences and storage fallback behavior for StableRoute-Org#27.
Contributor
|
hey @xx7412421-cloud, thanks for the effort here 🙏 issue #27 isn't assigned to you though — to keep the campaign fair and avoid duplicate work, please claim/get assigned to it first, then open your PR. closing for now; would love to see it back once it's assigned to you 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
Summary
stableroute.themestorage key with the script builderValidation
npm test -- themeScript.test.ts --runInBandnpm test -- --runInBandnpm run lintnpm run build