Skip to content

refactor: route quote page through apiClient#40

Closed
gaoflow wants to merge 1 commit into
StableRoute-Org:mainfrom
gaoflow:refactor/quote-01-apiclient-toast
Closed

refactor: route quote page through apiClient#40
gaoflow wants to merge 1 commit into
StableRoute-Org:mainfrom
gaoflow:refactor/quote-01-apiclient-toast

Conversation

@gaoflow

@gaoflow gaoflow commented Jun 21, 2026

Copy link
Copy Markdown

Summary

  • route quote requests through the shared apiGet/apiClient path
  • add success and API/network failure toast feedback while keeping inline status/alert regions
  • extend quote tests for URL encoding, multi-hop success, ApiError bodies, network rejection, validation guards, and loading state

Closes #1

Tests

  • npm test -- src/app/quote/page.test.tsx --runInBand
  • npm run lint
  • npm test -- --runInBand
  • npm run build
  • NEXT_PUBLIC_STABLEROUTE_API_BASE=http://localhost:3011 npm run build
  • Rendered smoke: started a temporary mock quote API on 3011 and production Next server on 3010, then captured /quote with Playwright CLI.

Browser runtime fallback: the in-app Browser was available as a skill, but the runtime returned Browser is not available: iab; I used Playwright CLI screenshots instead.

Screenshot evidence saved locally:

  • /tmp/stableroute-quote-apiclient-toast.png

@mikewheeleer

Copy link
Copy Markdown
Contributor

thanks for jumping in @gaoflow! 🙏 we assign issues before work starts so two people don't build the same thing, and #1 isn't assigned to you. please grab an open unassigned issue and PR against that. closing this one for now, hope to see you back 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Route the quote page through the shared apiClient and surface results via toast notifications

2 participants