fix(spacer): complete atom review#165
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the Spacer atom review by migrating it from inline-style spacing to token-based Tailwind/CVA-driven spacing, adding a clearer axis/size API while keeping legacy directional overrides, and rounding it out with tests and updated Storybook examples.
Changes:
- Reworked
Spacerto render spacing via Tailwind classes computed byuseSpacer(axis/size + spaceX/spaceY overrides) and defaultaria-hiddenbehavior. - Added a typed spacing scale map + CVA variants in
types.tsto keep spacing aligned with the design-token scale. - Added unit/component tests and refreshed Storybook stories to visualize spacing between markers.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/atoms/spacer/useSpacer.ts | Computes resolved spacing (axis/size + overrides) and returns merged className + ariaHidden. |
| src/components/atoms/spacer/types.ts | Introduces CVA variants and a constrained, token-aligned spacing scale type. |
| src/components/atoms/spacer/Spacer.tsx | Switches Spacer rendering to class-based layout and applies aria-hidden. |
| src/components/atoms/spacer/Spacer.test.tsx | Adds tests for hook logic and component aria-hidden / className behavior. |
| src/components/atoms/spacer/Spacer.stories.tsx | Updates stories to demonstrate default, axis variants, and legacy overrides via markers. |
| src/components/atoms/spacer/index.ts | Updates exports to match named Spacer export. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the Spacer atom review checklist.
Closes #135
Type of change
Component checklist (skip if not applicable)
types.ts,use*.ts,Component.tsx,index.ts,*.stories.tsx)types.ts, not inlinetheme.cssanytypes — TypeScript strictHow to test
pnpm test -- src/components/atoms/spacer/Spacer.test.tsxpnpm exec tsc --noEmitpnpm exec biome check src/components/atoms/spacerpnpm run storybook-buildScreenshots / recordings (if applicable)
Not included.
Notes for reviewer
aria-hiddenby default.