fix(link): complete atom review#168
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Completes the Link atom review by tightening behavior, accessibility semantics, visual variants, theme shadow aliases, stories, and unit coverage.
Changes:
- Reworks Link props, CVA variants, named export, disabled/action-mode behavior, and keyboard activation.
- Adds Tailwind shadow aliases for CTA glow utilities.
- Replaces Link stories and adds focused behavior tests for hook/component behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/styles/theme.css |
Adds shadow utility aliases for button glow tokens. |
src/components/atoms/link/useLink.ts |
Centralizes derived Link state, class generation, rel/role/disabled behavior, and event handlers. |
src/components/atoms/link/types.ts |
Updates Link variants, sizes, shadow option, and prop typing. |
src/components/atoms/link/Link.tsx |
Renders the updated accessible anchor/action behavior with named export. |
src/components/atoms/link/Link.test.tsx |
Adds hook and component behavior tests. |
src/components/atoms/link/Link.stories.tsx |
Reworks Storybook coverage for variants, sizes, states, targets, and action semantics. |
src/components/atoms/link/index.ts |
Updates the component barrel to export the named Link component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nto fix/link-atom-review-complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the Link atom review and validation.
Closes #132
Type of change
Component checklist (skip if not applicable)
types.ts,use*.ts,Component.tsx,index.ts,*.stories.tsx)types.ts, not inlinetheme.cssanytypes — TypeScript strictHow to test
pnpm test -- src/components/atoms/link/Link.test.tsxpnpm exec tsc --noEmitpnpm run buildpnpm run storybook-buildAtoms/Linkand verify inline, CTA, shadow, size, disabled, target, and action-mode stories.Screenshots / recordings (if applicable)
Not included.
Notes for reviewer
regularis now a true inline link;buttonmaps to primary CTA;outlinedmaps to secondary CTA.shadow={false}disables CTA glow while preserving focus ring accessibility.src/styles/theme.cssadds Tailwind shadow utility aliases for existing--glow-btn-*tokens soshadow-glow-btn-*classes generate correctly.