Skip to content

fix(link): complete atom review#168

Merged
egdev6 merged 4 commits into
mainfrom
fix/link-atom-review-complete
May 18, 2026
Merged

fix(link): complete atom review#168
egdev6 merged 4 commits into
mainfrom
fix/link-atom-review-complete

Conversation

@egdev6
Copy link
Copy Markdown
Member

@egdev6 egdev6 commented May 18, 2026

Summary

Completes the Link atom review and validation.

  • Fixes Link action-mode accessibility, including keyboard activation and disabled behavior.
  • Aligns Link visual variants with Stack-and-Flow inline/CTA semantics and exposes glow shadow utilities.
  • Reworks Link stories and adds focused unit coverage for Link behavior.

Closes #132

Type of change

  • 🧩 New component
  • 🐛 Bug fix
  • 🎨 Design tokens
  • ♿ Accessibility
  • 🏗️ Infrastructure
  • 📚 Documentation

Component checklist (skip if not applicable)

  • Follows the 5-file structure (types.ts, use*.ts, Component.tsx, index.ts, *.stories.tsx)
  • CVA variants defined in types.ts, not inline
  • No hardcoded colors — uses tokens from theme.css
  • No any types — TypeScript strict
  • ARIA attributes present and correct
  • Keyboard navigable (Tab, Enter, Escape where applicable)
  • Dark mode works correctly
  • Storybook stories cover: default, variants, states (hover, focus, disabled)
  • Tests added or updated

How to test

  1. pnpm test -- src/components/atoms/link/Link.test.tsx
  2. pnpm exec tsc --noEmit
  3. pnpm run build
  4. pnpm run storybook-build
  5. Navigate to Atoms/Link and verify inline, CTA, shadow, size, disabled, target, and action-mode stories.

Screenshots / recordings (if applicable)

Not included.

Notes for reviewer

  • regular is now a true inline link; button maps to primary CTA; outlined maps to secondary CTA.
  • shadow={false} disables CTA glow while preserving focus ring accessibility.
  • src/styles/theme.css adds Tailwind shadow utility aliases for existing --glow-btn-* tokens so shadow-glow-btn-* classes generate correctly.
  • Fresh pre-PR review passed. Review workload note: the diff is bounded to Link plus theme aliases, but it is over 400 changed lines due to story/test coverage.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Completes the Link atom review by tightening behavior, accessibility semantics, visual variants, theme shadow aliases, stories, and unit coverage.

Changes:

  • Reworks Link props, CVA variants, named export, disabled/action-mode behavior, and keyboard activation.
  • Adds Tailwind shadow aliases for CTA glow utilities.
  • Replaces Link stories and adds focused behavior tests for hook/component behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/styles/theme.css Adds shadow utility aliases for button glow tokens.
src/components/atoms/link/useLink.ts Centralizes derived Link state, class generation, rel/role/disabled behavior, and event handlers.
src/components/atoms/link/types.ts Updates Link variants, sizes, shadow option, and prop typing.
src/components/atoms/link/Link.tsx Renders the updated accessible anchor/action behavior with named export.
src/components/atoms/link/Link.test.tsx Adds hook and component behavior tests.
src/components/atoms/link/Link.stories.tsx Reworks Storybook coverage for variants, sizes, states, targets, and action semantics.
src/components/atoms/link/index.ts Updates the component barrel to export the named Link component.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/atoms/link/useLink.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comment thread src/components/atoms/link/Link.tsx
@egdev6 egdev6 merged commit 2923fb1 into main May 18, 2026
6 checks passed
@egdev6 egdev6 deleted the fix/link-atom-review-complete branch May 18, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

atom: Link — review and complete

2 participants