Mt/ops#3
Conversation
- Rename typecheck to type-check with --noEmit to match CI workflow - Add placeholder test script for CI test job - Fix conditional React.useId() call in Checkbox (rules-of-hooks) - Replace useState+useEffect with useSyncExternalStore in useMounted - Add CI workflow, .npmrc, .nvmrc, and PR template
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR introduces CI/CD infrastructure, tooling configuration, and code improvements. One critical security issue requires immediate attention.
Critical Issues
- Security vulnerability: npm security audits are disabled in
.npmrc, preventing detection of vulnerable dependencies
Changes Overview
- ✅ Added CI/CD pipeline with lint, typecheck, test, and build jobs
- ✅ Added PR template for consistent contribution process
- ✅ Standardized Node.js version with
.nvmrc - ✅ Improved
useMountedhook usinguseSyncExternalStorefor better hydration handling - ✅ Refactored checkbox component for clearer code structure
⚠️ Disabled npm security audits (needs fix)
Action Required: Address the security issue by enabling npm audit before merging.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| @@ -0,0 +1,2 @@ | |||
| fund=false | |||
| audit=false No newline at end of file | |||
There was a problem hiding this comment.
🛑 Security Risk: Disabling npm audit prevents detection of known security vulnerabilities in dependencies. Remove audit=false or set to true to enable security checks during installation.1
| audit=false | |
| fund=false |
Footnotes
-
CWE-1104: Use of Unmaintained Third Party Components - https://cwe.mitre.org/data/definitions/1104.html ↩
- Remove audit=false from .npmrc to re-enable security checks - Add npm audit step to CI pipeline (audit-level=high) - Update next 16.1.1 -> 16.1.6 (fixes 3 high severity CVEs) - Update flatted to fix unbounded recursion DoS
1 participant
No description provided.