Skip to content

fix: wrap fields in form#13

Merged
adefreitas merged 2 commits into
mainfrom
fix-wrap-fields-in-form
Sep 1, 2025
Merged

fix: wrap fields in form#13
adefreitas merged 2 commits into
mainfrom
fix-wrap-fields-in-form

Conversation

@adefreitas

@adefreitas adefreitas commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

Summary by cubic

Fixes form validation and submission in the integration picker so all fields behave as a single, accessible form. Also updates Malachite to 0.5.1.

  • Bug Fixes

    • Wrapped field rendering in the Malachite Form component to enable proper validation, keyboard submit, and semantics.
  • Dependencies

    • Bumped @stackone/malachite from 0.5.0 to 0.5.1.

Copilot AI review requested due to automatic review settings September 1, 2025 09:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a Form wrapper component around the integration field inputs to improve form handling and structure.

  • Imports the Form component from the @stackone/malachite library
  • Wraps the existing field mapping logic within a Form component
  • Updates the malachite dependency to version 0.5.1

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/modules/integration-picker/components/IntegrationFields.tsx Adds Form import and wraps field rendering logic in Form component
package.json Updates @stackone/malachite dependency from 0.5.0 to 0.5.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/modules/integration-picker/components/IntegrationFields.tsx Outdated
@adefreitas adefreitas merged commit c3114a8 into main Sep 1, 2025
2 checks passed

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

You're on the cubic free plan with 5 free PR reviews remaining this month. Upgrade for unlimited reviews.

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

Comment thread src/modules/integration-picker/components/IntegrationFields.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants