Skip to content

feat(ENG-520): update expressions package#171

Closed
jpmiguel wants to merge 2 commits into
mainfrom
eng-520/update-expressions
Closed

feat(ENG-520): update expressions package#171
jpmiguel wants to merge 2 commits into
mainfrom
eng-520/update-expressions

Conversation

@jpmiguel

@jpmiguel jpmiguel commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 3, 2026 15:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the @stackone/hub package’s dependency on @stackone/expressions to a newer release, along with the corresponding lockfile resolution changes.

Changes:

  • Bump @stackone/expressions from ^0.16.0 to ^0.34.0.
  • Refresh package-lock.json to reflect the new dependency graph (notably @stackone/utils moving to ^1.0.0 via @stackone/expressions).
  • Minor package.json formatting cleanup for files and sideEffects.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Updates @stackone/expressions version and minor formatting.
package-lock.json Re-locks dependencies for the updated @stackone/expressions version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
@jpmiguel jpmiguel requested a review from adefreitas June 15, 2026 08:37
@adefreitas

Copy link
Copy Markdown
Collaborator

Closing in favour of #173. Rather than bumping @stackone/expressions (which statically imports Node crypto and breaks browser bundlers like rsbuild), #173 removes the package from the hub entirely — the API already pre-renders connector configField value expressions server-side via GET /hub/connectors/:id, so client-side evaluation was redundant. Server-side resolution is guarded by StackOneHQ/unified-cloud-api#8344.

@adefreitas adefreitas closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants