feat(ENG-1065): oauth flow#3
Merged
Merged
Conversation
Collaborator
Author
|
will 🤠 and push to main |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements OAuth2 flow support for the integration picker, adding the ability to handle OAuth2 authentication in addition to existing custom authentication methods.
- Adds OAuth2 authentication type support with popup window handling
- Introduces message-based communication between parent and OAuth popup windows
- Adds new
dashboardUrlconfiguration to support OAuth callback URLs
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/integration-picker/types.ts | Adds type field to connector config for authentication method identification |
| src/modules/integration-picker/hooks/useIntegrationPicker.ts | Implements OAuth2 flow logic, popup window management, and message event handling |
| src/modules/integration-picker/components/IntegrationFields.tsx | Updates field key handling to support object-type keys with JSON stringification |
| src/modules/integration-picker/IntegrationPicker.tsx | Passes through dashboardUrl prop and adjusts connector data access |
| src/StackOneHub.tsx | Adds appUrl prop and derives dashboardUrl with default fallback |
| dev/main.tsx | Adds development environment support for appUrl configuration |
jpmiguel
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.