fix(ENG-9924): oauth flow button state#5
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the OAuth flow button state by preventing buttons from being rendered during loading states. The implementation adds loading state awareness to the integration picker card footer to improve user experience during authentication flows.
- Added
isLoadingprop toCardFootercomponent to control button visibility during loading states - Updated
IntegrationPickerto pass connection loading state to the footer component - Updated
@stackone/malachitedependency from v0.3.1 to v0.3.2
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/modules/integration-picker/components/cardFooter.tsx | Added isLoading prop and logic to hide buttons during loading states |
| src/modules/integration-picker/IntegrationPicker.tsx | Passed connectionState.loading to CardFooter component |
| package.json | Updated @stackone/malachite dependency to v0.3.2 |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
No issues found across 3 files. Review in cubic
jpmiguel
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixed the OAuth flow button so it stays disabled while loading, preventing users from clicking during connection attempts.