Skip to content

feat(ENG-7974): show failed connection errors#8

Merged
adefreitas merged 1 commit into
mainfrom
ENG-7973/show-failed-connection-errors
Aug 19, 2025
Merged

feat(ENG-7974): show failed connection errors#8
adefreitas merged 1 commit into
mainfrom
ENG-7973/show-failed-connection-errors

Conversation

@adefreitas

@adefreitas adefreitas commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator
Screen.Recording.2025-08-19.at.10.33.54.mov

Summary by cubic

Show failed connection errors in the Integration Picker, with a clear error message and a pretty JSON viewer for provider responses at the top of the form. Applies to both OAuth and test-connection failures, matching ENG-7973.

  • New Features

    • Show an error alert at the top with a JSON viewer of provider_response.
    • Unify OAuth and test-connection error display in the same place.
    • Remove the unused guide UI from the form.
  • Dependencies

    • Upgrade @stackone/malachite to 0.5.0 to use the CodeBlock JSON viewer (via @uiw/react-json-view).

Copilot AI review requested due to automatic review settings August 19, 2025 09:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances error display for failed integration connections by improving error visualization and removing unused guide functionality. The changes focus on making connection errors more readable and accessible to users.

  • Removes unused guide parameter and related code across integration components
  • Upgrades malachite UI library from v0.3.2 to v0.5.0 to support enhanced error display
  • Replaces basic text error display with a structured CodeBlock component for JSON error responses

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/modules/integration-picker/components/views/IntegrationFormView.tsx Removes guide parameter from props and component usage
src/modules/integration-picker/components/IntegrationPickerContent.tsx Removes guide parameter from props and passes through to child components
src/modules/integration-picker/components/IntegrationFields.tsx Updates error display to use CodeBlock for JSON responses and removes guide functionality
src/modules/integration-picker/IntegrationPicker.tsx Removes guide parameter from component props
package.json Upgrades @stackone/malachite dependency from v0.3.2 to v0.5.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread src/modules/integration-picker/components/IntegrationFields.tsx Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

Comment thread src/modules/integration-picker/components/IntegrationFields.tsx Outdated
@adefreitas adefreitas requested a review from jpmiguel August 19, 2025 10:13
@adefreitas adefreitas force-pushed the ENG-7973/show-failed-connection-errors branch from 365836a to 0b9569d Compare August 19, 2025 13:16
@adefreitas adefreitas merged commit 019b578 into main Aug 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants