feat(ENG-7974): show failed connection errors#8
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error display for failed integration connections by improving error visualization and removing unused guide functionality. The changes focus on making connection errors more readable and accessible to users.
- Removes unused guide parameter and related code across integration components
- Upgrades malachite UI library from v0.3.2 to v0.5.0 to support enhanced error display
- Replaces basic text error display with a structured CodeBlock component for JSON error responses
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/modules/integration-picker/components/views/IntegrationFormView.tsx | Removes guide parameter from props and component usage |
| src/modules/integration-picker/components/IntegrationPickerContent.tsx | Removes guide parameter from props and passes through to child components |
| src/modules/integration-picker/components/IntegrationFields.tsx | Updates error display to use CodeBlock for JSON responses and removes guide functionality |
| src/modules/integration-picker/IntegrationPicker.tsx | Removes guide parameter from component props |
| package.json | Upgrades @stackone/malachite dependency from v0.3.2 to v0.5.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
365836a to
0b9569d
Compare
jpmiguel
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-08-19.at.10.33.54.mov
Summary by cubic
Show failed connection errors in the Integration Picker, with a clear error message and a pretty JSON viewer for provider responses at the top of the form. Applies to both OAuth and test-connection failures, matching ENG-7973.
New Features
Dependencies