Skip to content

feat: add mute-when-focused toggle (+ make-dev watcher fix)#19

Merged
StuBehan merged 2 commits into
StackOneHQ:mainfrom
StuBehan:feat/mute-when-focused-toggle
Apr 30, 2026
Merged

feat: add mute-when-focused toggle (+ make-dev watcher fix)#19
StuBehan merged 2 commits into
StackOneHQ:mainfrom
StuBehan:feat/mute-when-focused-toggle

Conversation

@StuBehan

@StuBehan StuBehan commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Surfaces the existing frontmost-window suppression as a configurable toggle (`STACKNUDGE_MUTE_WHEN_FOCUSED`, default `true` to preserve current behaviour). When off, banners + voice fire regardless of which window is focused.
  • Wires the toggle through `notify.sh`, the panel's Settings page (new row in the Toggles section), and the menu-bar dropdown.
  • Fixes `make dev`'s watcher: `notify.sh` and `phrases/` were in `WATCH_DIRS` but the find filter was scoped to `.swift` / `Info.plist`, so shell-script edits never triggered a reload. Adds `.sh` to the filter and drops the `notifier/` dir (its sources were removed in the single-binary refactor — only `notifier/Icon.icns` is still used at build time).

Test plan

  • `make build` — single-binary app compiles clean (arm64)
  • `shellcheck --severity=warning notify.sh` passes
  • `bash -n notify.sh` passes
  • Manually toggle `Mute when focused` from the panel UI and confirm banner/voice fire when off, suppress when on
  • Manually toggle from the menu-bar dropdown and confirm parity with panel UI
  • Edit `notify.sh` while `make dev` is running, confirm reload triggers

StuBehan and others added 2 commits April 30, 2026 22:29
WATCH_DIRS listed notify.sh and phrases/ but the find filter was scoped to
*.swift / Info.plist, so shell-script changes never triggered a reload even
though `make reload` does propagate them. Also drops `notifier/` from the
watch list — its sources were removed in the single-binary refactor; only
notifier/Icon.icns is still used at build time.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Surfaces the existing frontmost-window suppression as a configurable toggle
(STACKNUDGE_MUTE_WHEN_FOCUSED, default true to preserve current behaviour).
When off, banners + voice fire regardless of which window is focused.

Wired through notify.sh, the panel's Settings page (new toggle row in the
Toggles section), and the menu-bar dropdown.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@StuBehan StuBehan merged commit 64d70e3 into StackOneHQ:main Apr 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant