fix: report correct CFBundleShortVersionString in installed bundles#33
Merged
Conversation
PR #32 wired release-please to sync `panel/Info.plist` on each release, but its merge commit was tagged `chore:` and release-please skipped it under default conventional-commit rules. As a result, no release fired and the sync mechanism didn't actually exercise. This empty `fix:` commit gives release-please a reason to act so the next release tag ships with a correctly-bumped Info.plist — fixing the user-facing bug where installed `stack-nudge.app` reports a stale version (currently `1.1.2`) in Settings → About and via the auto-update checker. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Empty
fix:commit to trigger release-please now that the Info.plist sync mechanism from #32 is in place.Why
#32 wired release-please's
extra-filesto keeppanel/Info.plistin sync on every release. But its merge commit was taggedchore:, which release-please ignores under default conventional-commits rules — so the sync mechanism never actually ran.Result:
main's Info.plist now reads1.4.1(the value committed in #32), but no new tag has fired, so users who download from the v1.4.1 release still get a bundle reportingCFBundleShortVersionString = 1.1.2. That's a real user-facing bug — Settings → About shows the wrong version, and the upcoming in-app auto-updater (onfeat/notification-customization) compares against this stale value and would always think an update is available.This
fix:commit gives release-please a reason to act so the next release (v1.4.2) ships with a correctly-bumped Info.plist.Test plan
manifest.jsonANDInfo.plistto1.4.2v1.4.2tag firesstack-nudge.appand confirmdefaults read .../Info CFBundleShortVersionStringis1.4.2(not1.4.1)feat/notification-customization: install v1.4.2 and verify the auto-updater no longer surfaces a false "update available" prompt🤖 Generated with Claude Code