chore(ci): consolidate lint and test workflows into single CI workflow#176
Merged
Conversation
- Merge lint.yaml and test.yaml into ci.yaml - Add Nix environment initialisation step after setup - Run lint, typecheck, build, and tests in sequence - Reduces workflow overhead by sharing setup steps
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the separate lint.yaml and test.yaml workflows into a single ci.yaml workflow file, improving CI efficiency by sharing setup steps and reducing workflow overhead.
Key changes:
- Merged two workflows into one, eliminating duplicate setup steps
- Added Nix environment initialization step to pre-warm the cache before running commands
- Renamed workflow from "Lint & Type Check" to "CI" and job from "lint" to "ci"
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/test.yaml |
Removed standalone test workflow (functionality moved to ci.yaml) |
.github/workflows/ci.yaml |
Extended to include tests; added Nix environment initialization step for cache warming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Compare pnpm-lock.yaml timestamp against node_modules/.pnpm/lock.yaml to determine if installation is needed. This avoids redundant installs when entering the Nix development shell multiple times. - Check if node_modules/.pnpm/lock.yaml exists - Compare timestamps using -nt (newer than) - Use --frozen-lockfile to ensure lockfile consistency
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Include version control tools in the Nix development environment for consistent tooling across all developers.
This reverts commit 2a5c6f5.
NicolasBelissent
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lint.yamlandtest.yamlinto a singleci.yamlworkflownix develop --command true) after setup to pre-warm the cacheBenefits
Test plan
Summary by cubic
Replaced separate lint and test workflows with a single CI workflow to reduce setup duplication and speed up runs with a pre-warmed Nix environment. The job runs lint, typecheck, build, and tests in sequence.
Written for commit 7a0a4b8. Summary will update automatically on new commits.