Packaging: Add directories and symlinks to deb/rpm packages #6327
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| nfpm_content_dirs( | ||
| name="root_dirs", | ||
| dirs=[ | ||
| # "/etc/bash_completion.d", | ||
| # "/etc/logrotate.d", | ||
| "/etc/st2", | ||
| "/opt/stackstorm", | ||
| "/opt/stackstorm/st2", | ||
| "/usr/share/doc/st2", | ||
| ], | ||
| file_owner="root", | ||
| file_group="root", | ||
| file_mode="rwxr-xr-x", | ||
| ) | ||
|
|
||
| nfpm_content_dirs( | ||
| name="packs_group_dirs", | ||
| dirs=[ | ||
| "/opt/stackstorm/packs", | ||
| "/opt/stackstorm/virtualenvs", | ||
| "/usr/share/doc/st2/examples", | ||
| ], | ||
| file_owner="root", | ||
| file_group=ST2_PACKS_GROUP, | ||
| file_mode="rwxrwxr-x", | ||
|
Comment on lines
+23
to
+25
Member
Author
|
||
| ) | ||
|
|
||
| nfpm_content_dirs( | ||
| name="st2_user_dirs", | ||
| dirs=[ | ||
| "/opt/stackstorm/configs", | ||
| "/opt/stackstorm/exports", | ||
| "/opt/stackstorm/overrides", | ||
| "/var/log/st2", | ||
| "/var/run/st2", | ||
| ], | ||
| file_owner=ST2_SVC_USER, | ||
| file_group="root", | ||
| file_mode="rwxr-xr-x", | ||
|
Comment on lines
+37
to
+39
Member
Author
|
||
| ) | ||
|
|
||
| target( | ||
| name="dirs", | ||
| dependencies=[ | ||
| ":root_dirs", | ||
| ":packs_group_dirs", | ||
| ":st2_user_dirs", | ||
| ], | ||
| ) | ||
|
Comment on lines
+42
to
+49
Member
Author
There was a problem hiding this comment. Each set of directories above ( |
||
|
|
||
| nfpm_content_symlinks( | ||
| name="symlinks", | ||
| symlinks=[ | ||
| # the symlink src will be made available during post-install script | ||
| (f"/opt/stackstorm/st2/bin/{cmd}", f"/usr/bin/{cmd}") | ||
| for cmd in ( | ||
| "st2", | ||
| "st2-trigger-refire", | ||
| "st2-rule-tester", | ||
| "st2-run-pack-tests", | ||
| "st2-register-content", | ||
| "st2-apply-rbac-definitions", | ||
| "st2-bootstrap-rmq", | ||
| "st2-generate-symmetric-crypto-key", | ||
| "st2-self-check", | ||
| "st2-track-result", | ||
| "st2-validate-pack-config", | ||
| "st2ctl", | ||
| ) | ||
| ], | ||
| file_owner="root", | ||
| file_group="root", | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is defined in https://github.com/StackStorm/st2-packages/blob/master/packages/st2/debian/st2.dirs but I don't think they're necessary. When we add the files that go in these directories, the directories will be implicitly added, and we don't have specific permissions to set on these directories as we assume they will be created by the relevant package that owns the directory.
So, I left it commented out. I can either remove them now, or we can remove them once the files that go in these directories get registered (in a follow-up PR).