-
-
Notifications
You must be signed in to change notification settings - Fork 779
Update pytest-cov version requirement and fix other build failures #6363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While Stackstorm supports python 3.8 (rocky8), pytest-cov needs to be downgraded to 5.0.0
|
I've re-run the tests that failed and they're all passing. Thank you for fixing this. 👍 |
…6363) * Update pytest-cov version requirement While Stackstorm supports python 3.8 (rocky8), pytest-cov needs to be downgraded to 5.0.0 * Update changelog * Pin DOCKER_API_VERSION * Pin pynacl, newer versions cause build conflicts * Undo local compatability changes * Note in changelog about pinning the DOCKER_API_VERSION * Regen pants lockfile
| '>7' | ||
| '>=4.0.3' | ||
| '>=6.1.1' | ||
| '>=5.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the GHA workflow to regenerate the lockfile should learn to deal with this file somehow.
This file is not a simple "copy the locked version", so we'd need to be careful to not turn that workflow into a maintenance headache.
1# pytest-cov fix
While Stackstorm supports python 3.8 (rocky8), pytest-cov needs to be downgraded to 5.0.0. This was updated in #6340
Fresh 3.9 install on Rocky8
2# pin DOCKER_API_VERSION
According to https://circleci.com/docs/guides/execution-managed/building-docker-images/ circleci currently supports up to
docker24however installing the latest docker-cli uses an API version that docker24 does not support. Thus we can pin it to1.43which is the maximum API version allowed with docker243# pin pynacl
The newest version of pynacl (pulled in by paramiko) requires a newer version of cffi than we pin, so pin pynacl at 1.6.0