fix: 1.12 bug sweep — mod container, planet config, JEI guard, per-dim time/beds, planet weather sync

.agent/DEVELOPMENT-README.md

@@ -8,6 +8,37 @@
 
 ## ⚠️ Required reading before any non-trivial work
 
+### At session start + before working any bug report
+
+**[SOP: Bug-report workflow](./sops/development/bug-report-workflow.md)** —
+read at the start of every session, and before fixing any reported
+issue/bug.
+
+**TL;DR**: the pipeline is repro-FIRST → trace report → user decides.
+(1) Write reproduction tests against the clean default build before
+touching production — **a `testClient` e2e is mandatory** (plus a
+`testServer` e2e when the bug is catchable there); they confirm the
+bug now and guard regression forever. (2) Only after the behaviour is
+confirmed, deliver a structured trace report: cause (`file:line`),
+provenance (when it was introduced), and fix options. (3) The user
+picks: **Path A** — file a `Type: Bug report — confirmed` /
+`Priority: urgent` task (status `Backlog`), fix deferred; **Path B** —
+fix now, flip the repro tests to the corrected contract, close the
+task. **Session-start duty**: scan `tasks/` for open
+`Type: Bug report — confirmed` tasks and offer to fix them.
+
+### Before writing any issue reference (commit / PR / TASK / ledger)
+
+**[SOP: Issue-reference discipline](./sops/development/issue-reference-discipline.md)** —
+read before referencing an issue number anywhere.
+
+**TL;DR**: this repo is in a GitHub fork network
+(`Advanced-Rocketry` root → `StannisMod` → `dercodeKoenig`). A **bare
+`#NN` leaks to the root** and notifies unrelated 2015-era issues —
+never use it. **Always fully-qualify** as `owner/AdvancedRocketry#NN`
+using the `owner/repo` from the issue link the user gave you (it may be
+`StannisMod` or `dercodeKoenig`). Never reference the root.
+
 ### Before writing or auditing tests
 
 **[SOP: Testing Principles](./sops/development/testing-principles.md)** —

.agent/audits/2026-05-27-full-coverage-audit.md

@@ -250,7 +250,7 @@ assembly + at least one recipe end-to-end + power-drain pin via
 | Per-dimension weather isolation | Deep (TASK-09 `PerDimensionWeatherIsolationTest`) |
 | Non-AR dimension exclusion | Deep (`NonARDimensionIsolationTest`) |
 | Weather persistence | Deep (`WeatherPersistenceTest`, `PlanetWeatherSavedDataTest`) |
-| Weather sync to client | Deep (`WeatherClientSyncE2ETest`, `ARWeatherWorldInfoTest`) |
+| Weather sync to client | Deep (`WeatherClientSyncE2ETest`, `ARDimensionWorldInfoTest`) |
 | Worldgen determinism (within-session) | Deep (`WorldgenDeterminismAndSamplingTest`) |
 | Worldgen cross-session reboot determinism | **Non-goal** (README §"Conscious non-goals") |
 | OreGen properties registry | Deep (`OreGenPropertiesTest`) |

.agent/audits/2026-06-11-honest-e2e-delta.md

@@ -0,0 +1,84 @@
+# Honest-client-e2e delta — 2026-06-11
+
+**Branch**: `fix/various`
+**Parent audits**: [`2026-05-27-full-coverage-audit.md`](./2026-05-27-full-coverage-audit.md),
+[`2026-05-29-coverage-delta.md`](./2026-05-29-coverage-delta.md)
+**Trigger**: full sweep of the testClient tier against
+[`sops/development/honest-client-e2e.md`](../sops/development/honest-client-e2e.md)
+(the SOP postdates most of the tier — written 2026-06-03, tier mostly built in May).
+
+## Sweep verdicts (before → after)
+
+Of 29 client e2e classes audited: 9 honest, 6 partial, 13 false-green
+risk, 1 mislabeled. All 20 non-honest were remediated the same day:
+
+| Group | Tests | Remediation |
+|---|---|---|
+| `/ar` command tests | WorldCommandFetchTest, WorldCommandFetchModeratorTest, WorldCommandPlayerEquippedE2ETest | `exec-as-player` stimulus → real client chat (`sendChat`); outcomes read at the player layer (client position/dim/inventory/chat overlay), server probes demoted to oracles |
+| Ride tests | HovercraftRideE2ETest, ElevatorCapsuleRideE2ETest | throttle = real W key, dismount = real sneak; assertions via `reportRidingEntity` (mount stays a probe — SOP-allowed arrange) |
+| Item-use tests | ItemHovercraftSpawn, OreScannerRightClick, ItemAtmosphereAnalzer, ItemSealDetector, ItemBiomeChanger | real `useItem`/`interactBlock` clicks (+ `setLook` aim); observations via client entities / client screen / client chat (i18n resolved); arrange-only probe splits (`equip-orescanner`, `equip-biomechanger`, `satellite poslist-size`) |
+| Relabeled to testServer (user-approved) | VacuumGuards, Advancements→AdvancementsTrigger, LowGravFallDamage, AtmospherePlayerEvent | server-side handler contracts that the client tier drove via probes anyway; headless player supplied by `artest player ensure-fake` + `tick-living` |
+| Partial completions | RocketBuilderGui (client sees the spawned EntityRocket), suit ×2 + GasChargePad (client-rendered chest NBT) | player-layer completion asserts added |
+
+Remaining PARTIAL (accepted): `RailgunCargoTransitE2ETest` — stimulus and
+assertions are server probes; the cargo-transit contract is double-pinned at
+the server tier (`RailgunFiringContractTest`), and the client-visible surface
+(hatch GUI contents) needs a dedicated GUI leg. Candidate follow-up, not a
+silent exception.
+
+## Framework capabilities added (vendored testframework/)
+
+`send_chat`, `report_mods`, `use_item`, `interact_block` (week of 06-10),
+`report_chat`, `report_player_items`, `report_entities` (06-11) — each landed
+in the same commit as the first test using it.
+
+## Production bugs found by the sweep (all fixed on `fix/various`)
+
+Connectionless player-shaped entities (Forge FakePlayers — spawned by
+turtles/block-breakers/test harnesses) crashed AR server-side:
+
+1. `EntityEventHandler.onJoinWorld` / `onPlayerChangedDimension` —
+   unconditional `player.connection.sendPacket` (+ CCE-prone cast for non-MP
+   EntityPlayer impls). Guarded.
+2. `PlanetWeatherManager.syncToPlayer` — same. Guarded.
+3. `AtmosphereHandler.onTick` effect paths — potion sync +
+   `PacketOxygenState` (now via `AtmosphereType.sendToRealPlayer`) took the
+   server tick loop down for connectionless players in non-breathable dims.
+   Effects now skip them; cache/sync bookkeeping still runs.
+4. (Latent, found by the OreScanner rewrite) `ItemOreScanner.onItemRightClick`
+   casts the stored satellite id to `int` before the registry lookup — long
+   ids silently never resolve and the GUI never opens. Documented at the
+   probe; production fix not yet decided (ids are int-safe in practice).
+
+## Probe defect found (open)
+
+`artest server wait <dim> <ticks>` executes ON the server thread
+(console command), so its sleep-poll loop blocks ticking entirely: it
+returns `elapsedTicks:0` after burning its wall budget and stalls the
+server for the duration. Every existing caller got a silent no-op wait.
+Relocated tests wait off-thread (test-JVM sleep) instead. Follow-up:
+fix or retire the probe and sweep its callers (RocketDescentLandingTest
+et al.).
+
+## Flake note (same day)
+
+`WorldCommandFetchModeratorTest` (3 JVMs: server + 2 GL clients, ~7 GB):
+green standalone at 11:05 after the sendChat rewrite; from ~12:30 the
+first client's bridge dies seconds after world-join ("Client bridge
+closed unexpectedly" at the first waitTicks), reproducibly, while TWO
+sibling-session Minecraft clients run on the same box/display (pgrep
+evidence per the shared-box memory). Code unchanged between green and
+red. Verdict: shared-box display/RAM contention, not a test defect —
+re-run when the box is quiet before treating as a regression.
+`GuidanceComputerGuiE2ETest` and one `ItemSealDetector` method failed
+once in the full-suite run under the same load and passed on re-run
+(the seal test's chat poll was also hardened: 20-line window, 200-tick
+cap).
+
+## Coverage-audit cross-check (same sweep)
+
+The 2026-05-27/29/31 audit trio remains trustworthy: all Deep/Partial pins
+exist (one stale name fixed: `ARWeatherWorldInfoTest` →
+`ARDimensionWorldInfoTest`), every accepted §3 proposal shipped or tracked,
+no dangling debt. Pyramid counter: trust `tasks/README.md` (regen 2026-06-03)
+over audit snapshots.

.agent/history/known-bugs-ledger.md

@@ -4,9 +4,11 @@
 2026-05-23). Batch #2 below is **live** and is kept in sync with the
 summary in [`../tasks/README.md`](../tasks/README.md) bug-ledger section.
 
-**Live bug count (as of 2026-05-31)**: 4 live — Batch #2 entries
-#1, #3, #5, #7. Entry #2 dropped as impl-trivia, #4 fixed by TASK-41,
-#6 fixed by TASK-43 Phase 3 (see per-entry notes below).
+**Live bug count (as of 2026-06-10)**: 4 live — Batch #2 entries
+#1, #3, #5, #7. Entries #9–#12 backfilled 2026-06-10 for the PR #22
+issue fixes (all fixed on arrival; see per-entry pins + approved e2e
+exceptions). Entry #2 dropped as impl-trivia, #4 fixed by TASK-41,
+#6 fixed by TASK-43 Phase 3, #8 fixed by TASK-49 (see per-entry notes below).
 When a future production bug is uncovered, follow the rule in
 [`CLAUDE.md`](../../CLAUDE.md#bug-tracking--every-discovered-production-bug-must-be-logged)
 and append it to Batch #2 here AND to the README summary.
@@ -255,3 +257,81 @@ authoring that have not yet been fixed.
    `TilePumpFillsFromAdjacentWaterSourceTest` pins the real contract
    (drains an AR Forge-fluid source) and documents this in its docstring.
    **Found**: 2026-05-31 during TASK-44 Gap F.4 un-ignore.
+
+8. ✅ **FIXED 2026-06-03 by TASK-49.** `attemptCargoTransfer` now loads a
+   registered-but-unloaded destination dimension on fire
+   (`getWorld==null && isDimensionRegistered → initDimension → getWorld`,
+   the `TileSpaceElevator` idiom; the destination railgun's own `onLoad`
+   ticket sustains it after), and every non-firing outcome sets a
+   `FireStatus` (`NO_TARGET` / `TARGET_UNAVAILABLE` / `TARGET_FULL` /
+   `DIFFERENT_SYSTEM`) synced to the client and shown as a red GUI line —
+   no more silent no-op. Repro tests flipped to the corrected behaviour
+   (3 server + 2 client, green). Original description below.
+   **`TileRailgun.attemptCargoTransfer` fails silently — no player feedback
+   on any failure branch; the dominant field cause is an unloaded destination
+   dimension.** The railgun is a paired item-teleport: a source pulls a stack
+   from its input port and dispatches it to a linked destination railgun.
+   Firing is gated by ~5 AND-conditions and returns `false` with **no message**
+   when any fails. The most likely field failure (matching the related
+   Advanced-Rocketry#1172 "Station→Moon doesn't fire") is the destination being
+   in an unloaded dimension: production resolves it via
+   `net.minecraftforge.common.DimensionManager.getWorld(destDim)`, which
+   returns `null` for an unloaded dim, and the railgun only chunk-loads its OWN
+   chunk (`onLoad:252`), never the destination's.
+   File: `src/main/java/zmaster587/advancedRocketry/tile/multiblock/TileRailgun.java:309-364`
+   (silent `false` branches), `:340` (Forge `getWorld` → null on unloaded dim),
+   `:252` (own-chunk-only force-load).
+   **Consequence**: player-visible — "Railgun just does not fire" (#61). Sender
+   on planet A, receiver on planet B, player on A → B unloaded → nothing
+   happens, no feedback. Cargo is NOT lost (verified). Same-dimension firing
+   works. Other silent modes: no output hatch on the destination / output full,
+   redstone state not satisfied, insufficient RF/t, linker not re-targetable
+   without a sneak-`resetPosition`.
+   **Pinned by**: `RailgunFiringContractTest` —
+   `railgunFiresCargoToLinkedRailgunInSameDimension` (positive same-dim
+   contract) + `railgunSilentlyFailsWhenDestinationDimensionUnloaded`
+   (characterizes the silent unloaded-dest no-op + cargo-preservation), and at
+   client tier by `RailgunCargoTransitE2ETest` (same two contracts with a real
+   client connected). New `artest infra railgun-fire` probe verb drives the
+   source-side path.
+   Fix candidates (TASK-49): load/resolve the destination dim on fire +
+   surface a failure message per cause.
+   **Found**: 2026-06-02 during issue #61 investigation (TASK-49).
+
+9. ✅ **FIXED 2026-06-01 (PR #22, `7f8ee7f0`).** Vestigial `DummyModContainer`
+   (`advancedrocketrycore`) made the title screen count one more "loaded" mod
+   than "active" (dercodeKoenig/AdvancedRocketry#71). Backfilled entry — fixed
+   before this ledger row existed.
+   **Pinned by**: `ModCountParityE2ETest` (client tier, via the framework's
+   `report_mods` probe — the same `Loader` lists the menu line renders;
+   red-proven against the restored container).
+
+10. ✅ **FIXED 2026-06-01 (PR #22, `ae379cac`).** planetDefs.xml referencing
+   content from an uninstalled mod crashed world creation through a silent
+   `FMLCommonHandler.exitJava` — window closed, no crash report
+   (dercodeKoenig/AdvancedRocketry#77). Backfilled entry.
+   **Pinned by**: `XMLPlanetLoaderTest` (reserved-but-empty ore, per-planet
+   isolation) + `PlanetDefsFaultToleranceTest` (server tier: boots with a
+   dirty file, malformed planet skipped, good planet survives).
+   **Client e2e: approved exception (user, 2026-06-10)** — the symptom is the
+   client window closing on a server-side startup crash; the server-tier boot
+   pin covers the substance, a client shutter assert adds nothing.
+
+11. ✅ **FIXED 2026-06-01 (PR #22, `cac31155`).** `PacketDimInfo.executeClient`
+   touched the JEI `ARPlugin` unconditionally → `NoClassDefFoundError` without
+   JEI installed, re-introducing dercodeKoenig/AdvancedRocketry#76 via the
+   dimension-sync path. Backfilled entry.
+   **Pinned by**: nothing executable — **approved exception (user,
+   2026-06-10)**: reproducing needs a client WITHOUT JEI on the classpath, and
+   both harnesses always carry JEI; no no-JEI harness profile is planned.
+   Source-level guard (`Loader.isModLoaded("jei")`) audited at fix time.
+
+12. ✅ **FIXED 2026-06-02 (PR #22, `d1eb4794`) — e2e closed 2026-06-10.** Beds
+   skipped no time on AR planets and vanilla's 24000-rounded wake missed
+   planetary dawn (dercodeKoenig/AdvancedRocketry#66, TASK-47). Backfilled
+   entry.
+   **Pinned by**: `SleepWakeTimeTest` (dawn math), `ARDimensionWorldInfoTest`
+   (per-dim clock ownership), and since 2026-06-10 the live
+   `PlanetBedSleepE2ETest` (real client sleeps in a real bed via the
+   framework's `interact_block`; red-proven: without `MixinWorldServer` the
+   skip lands at vanilla 24000 — mid-night on a 30000-tick planet).