Rocket weight system + part wear & repair (TASK-45)#23
Merged
Conversation
- resolve block weight via individual/regex/material/fallback chain - add weights.json materials/byRegex/fluids sections + auto-seed - guard StatsRocket acceleration against zero weight - add thrust-to-weight ratio, canLaunch, dry acceleration getters - gate launch on configurable minLaunchTWR not zero margin - show TWR in assembler GUI, integrate burn for fuel sufficiency - scale fluid mass by fuelMassScale, material weight by scale - add weightMaterialScale, fuelMassScale, minLaunchTWR config keys - add /artest weight probe plus unit and server weight tests - ledger bug 8: getAcceleration divide-by-zero found and fixed
- warm chunks then fill air above pad before fixture build - mirrors RocketAssemblySmokeTest scan-flake mitigation - prevents biome terrain leaking into scan bbCache (cap=0)
- diagnose invisible wear, silent death, contraption repair - lock decisions: graduated consequences, config launch switch - two-tier repair with standalone recipe-ingredient x3 mode - phased plan, one commit per phase
- scale motor thrust by 1 - wearThrustPenaltyMax * stage/maxStage - add wearThrustPenaltyMax config key (default 0.5) - add TileBrokenPart.getMaxStage accessor - worn rocket loses TWR and can fail the launch gate - note tank/seat wear counters are dead (only motors wear)
- add IPartWear + CapabilityWear (mirrors CapabilitySpaceArmor) - TileBrokenPart implements IPartWear and exposes the capability - register the capability in postInit - route StorageChunk wear reads through the capability - behavior-preserving; enables wear on tanks/seats next
- extract TileWearable base (wear state + capability) from TileBrokenPart - TileBrokenPart now extends it, keeps motor render and staged drop - fuel tanks and seats host a TileWearable (TE-only wear, no meta/render) - register TileWearable; seats wear at 0.25x rate - wear is captured into the rocket storage chunk and ticked on landing
- worn tanks may leak at launch: bleed fuel and add explosion risk - worn seat blocks a crewed launch; uncrewed rockets still fly - pre-launch warning shows failure percent to the pilot - wearCriticalBlocksLaunch config refuses launch instead of exploding - add tank-leak and seat-block config keys; add lang strings
- damage-view panel lists all worn parts via the wear capability - motors show staged drop, tanks/seats show their block icon - drop WIP from service monitor and station tooltips
- add /artest wear get|set probe for world part-wear state - WearSystemTest: motors/tanks/seats host the wear capability - wear stage round-trips through the capability - fully-worn motors produce less thrust after assembly
… phase 3) - add input slots to the service station for repair materials - repair a worn motor from its recipe ingredients x config multiplier - assembler path stays the 1x option when an assembler is adjacent - count worn motors/tanks/seats via the wear capability - re-queue an in-flight part if its assembler vanishes mid-repair - inventory NBT is backward compatible with old saves
- expose breakingProb in rocket info probe - WearSystemTest: worn motor raises breaking probability - ledger #9: dead tank/seat worn counters found and fixed - note standalone-repair and launch-consequence E2E tests deferred
- WearSystemTest standalone repair: link, load ingot+plate, power, performFunction, assert worn motor restored to stage 0 - WearSystemTest surfaces worn tanks + critically-worn seat for the gate - ore-dict-tolerant material matching in standalone repair - add wear station-load (slot) and rocket-status probe verbs
- switch service station GUI from MODULARNOINV to MODULAR - expose repair inventory as ITEM_HANDLER capability for hoppers/pipes - compact GUI modules above the player-inventory zone
Each opt-in mechanic had config flags, but the flags didn't fully turn the mechanic off — a real complaint from players who were told these systems are optional. Close the leaks: - Weight: gate the TWR launch check inside StatsRocket.canLaunch() on advancedWeightSystem. It is the single source of truth, so the launch gate in EntityRocket is fixed too. With the system off there is no TWR-based refusal at all (classic behaviour). - Wear: gate accrual inside StorageChunk.damageParts() on partsWearSystem, so no part ever advances a wear stage while the system is off (the consequences were already gated). - Weather: gate WorldProviderPlanet.updateWeather()'s custom cycle on enableCustomPlanetWeather too, not only the XML markers — otherwise the cycle kept overwriting the shared overworld weather when disabled. - Weather mixins: new ARMixinPlugin (IMixinConfigPlugin) skips weaving the two weather mixins (MixinWorldServerMulti, MixinPlayerList) when custom planet weather is off; reads the cfg directly, fail-open. Tests (contract-level, per testing-principles SOP): - StatsRocketTest: +canLaunchIgnoresTwrGateWhenWeightSystemDisabled; two existing canLaunch tests realigned to the new contract (the TWR gate only exists when the weight system is on). - ARMixinPluginTest: weather mixins gated by flag, others always weave. - WearAccrualDisableTest (server): wear accrues only when the system is on. - WeatherCycleDisableTest (server): the forced-clear cycle runs only when the flag is on; with it off the rain we set survives a weather tick. Test probe additions (test-only): whitelist the four flags + minLaunchTWR for `config set`; `wear damage-parts`; `weather set-marker`/`tick-provider`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AdvancedRocketryPlugin's coremod constructor called MixinBootstrap.init()
unconditionally. In a packaged jar running under a Mixin host (MixinBooter),
Mixin is already bootstrapped on the LaunchClassLoader and our config is
registered from the MixinConfigs manifest attribute; re-running init() from
this coremod (AppClassLoader) re-initiates loading of
org.spongepowered.asm.launch.GlobalProperties$Keys on a second classloader,
the JVM throws a LinkageError ("loader constraint violation"), and FML crashes
at launch (reported by a modpack user on 2.1.10).
Wrap the self-bootstrap in try/catch: the dev workspace (no host, no manifest)
succeeds and self-registers as before; under a host the LinkageError is
swallowed and the manifest drives registration. Verified in dev that mixins
still apply (WeatherBaselineTest — per-dim weather wrapping — stays green).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Capture hard-won lessons (bug ledger, TASKs, this session) as reusable SOPs under .agent/sops/development/, and wire them into the navigator's required-reading + a full SOP index: - build-and-run-env, harness-capabilities-and-limits - mixin-coremod-dev-vs-prod (ledger #4/#6 + the MixinBooter launch crash) - config-flag-disableability, single-source-of-truth-gating - artest-probe-authoring, server-test-harness, test-fixtures-catalog - save-and-wire-compat, forge-capability-pattern - coverage-audit-playbook, verify-subagent-findings, bug-ledger-discipline - fix-propagation-across-branches Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Supersedes the earlier try/catch guard (0fd8a83), which was insufficient: catching the cross-classloader LinkageError still leaves a half-initialised Mixin service that poisons MixinBooter's MixinTweaker ("No mixin host service is available") and crashes the client at launch. The supported pattern: implement MixinBooter's IEarlyMixinLoader and return our config from getMixinConfigs(); the host queues it on the LaunchClassLoader in both dev and packaged environments. The coremod never touches Spongepowered classes on the AppClassLoader, so the LinkageError can't arise. Verified in dev that mixins still weave (WeatherBaselineTest — per-dim weather wrapping — green). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
getNeededThrust() returned getWeight()*minLaunchTWR unconditionally, so with advancedWeightSystem disabled the assembler GUI still displayed a TWR-based thrust requirement that no longer gates launch (canLaunch is always true then). Return 0 when the weight system is off. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- TASK-46-config-disableability.md added (Status ✅ Completed); Done row added - pyramid REGENERATED from source: 859 (273/82/443/61), correcting stale per-tier values drifted across TASK-44/45 - reconciled TASK-45 (closure had a marker but no README Done row) — Done row + Status line added - EOD marker saved + .active updated - bug ledger unchanged (leaks fixed, no new bugs) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… the navigator - prominent non-negotiable block in CLAUDE.md + DEVELOPMENT-README - expand Commit Guidelines + message template: no Co-Authored-By, no "Generated with", no assistant mention - frame it as overriding any default harness attribution behaviour
…SOPs SOP-compliance pass over the tests added on this branch. Four fixes, no contract changes: - StatsRocketTest: primeConfig (@BeforeClass) mutated rocketThrustMultiplier and rocketRequireFuel on the shared ARConfiguration singleton without a restore, leaking into every later unit test in the JVM. Save the previous values and restore them in @afterclass. - StatsRocketTest.dryAccelerationUsesEmptyTankWeight pinned the exact acceleration formula (the /20 scaling divisor is an implementation detail). Re-pin the contract instead: zero net force gives zero dry acceleration, thrust above dry weight gives positive, more thrust accelerates harder. - WeightEngineUnitTest pinned the 0.001 kN/mB fluid fallback constant. Pin the contract instead: an unknown fluid weighs something positive, weight is linear in amount, and fuelMassScale multiplies it (measured against a scale-1.0 baseline, not an absolute value). - WeatherCycleDisableTest matched "ARWeatherWorldInfo" anywhere in the weather get response; anchor it to the probe's named worldInfoClass field per the artest-probe-authoring SOP. Verified: full testUnit 273/273 green (cache-busted), WeatherCycleDisableTest green against a real server boot.
…) into feature/postponed Brings the 1.12 bug-sweep — mod-container removal, tolerant planetDefs, JEI guard, per-dim time/beds, planet weather sync, railgun Advanced-Rocketry#61 — plus TASK-45..51 docs and the vendored testframework/ build, onto the weight/wear feature line. Conflict resolution: - mixins.advancedrocketry.json: auto-merged cleanly — ARMixinPlugin (weave-gates the weather mixins) + MixinWorldServer both retained. - 4 client-e2e suites (Advancements / AtmospherePlayerEvent / LowGravFallDamage / VacuumGuards) deleted on 1.12 — accepted; coverage moved to server tier (1:1 named replacements exist). - WeatherCycleDisableTest: ARWeatherWorldInfo -> ARDimensionWorldInfo (1.12 class rename) so the probe-class assertion matches. - bug-ledger #8/#9 collision (postponed weight/TASK-45 vs 1.12 railgun/ PR#22) resolved by chronological renumber #8..#14; README pointer + inline entries + pyramid counter (regenerated 874) updated to match. compileJava + compileTestJava green (JDK25/RFG). Test suites not run.
… subsystem Single master flag (default true) gating ALL per-dimension WorldInfo overrides — per-planet weather AND per-planet time/sleep — at every layer: - ARMixinPlugin now weave-gates the THREE WorldInfo mixins (MixinWorldServerMulti / MixinWorldServer / MixinPlayerList) on perDimWorldInfo instead of gating only the two weather mixins on enableCustomPlanetWeather. This fixes the leak where weather-off accidentally un-wove the per-dim TIME mixin (MixinWorldServer rides the same wrapper). - PlanetWeatherManager.shouldWrap + isWeatherManaged gate on the master. - MixinWorldServer runtime-gates the sleep redirect on the master. - WorldProviderPlanet.updateWeather gates on the master. - enableCustomPlanetWeather retained as a weather SUB-toggle (managed vs delegated) that only takes effect when the master is on. perDimWorldInfo=false => no WorldInfo mixins woven, no wrapper, fully vanilla shared-overworld WorldInfo (weather + time). Supersedes the granular enablePerDimensionTime idea (TASK-51). ARMixinPluginTest updated to pin all three mixins gated + the off-state regression guard. compileJava+compileTestJava green (JDK25/RFG); ARMixinPluginTest green.
…states) PerDimWorldInfoMasterToggleTest — server-tier, SOP config-flag-disableability Rule 5 (both states, off-test is the regression guard): - masterOffLeavesPlanetOnVanillaWorldInfo: perDimWorldInfo=false → a freshly loaded planet keeps vanilla DerivedWorldInfo (no ARDimensionWorldInfo). - weatherOffButMasterOnKeepsTheWrapperForPerDimTime: master on + enableCustomPlanetWeather=false → planet STILL wrapped (per-dim time rides the wrapper); confirmed via weather get + dim time probes. Guards the leak where weather-off used to kill per-dim time. Adds perDimWorldInfo to the /artest config set whitelist. Pyramid 874→876 (testServer +2). 2/2 green on the real dedicated-server harness.
…iant (PR #23 #5) ServiceStationUnlinkedPerformFunctionTest — pins that performFunction on a powered but UNLINKED service station is a safe no-op. tryStandaloneRepair dereferences ((EntityRocket) linkedRocket).storage with no null check, but is only reachable from performFunction inside if (linkedRocket instanceof EntityRocket) (and unlinkRocket clears partsToRepair), so the deref is safe by construction. The probe wraps performFunction in try/catch, so removing the guard surfaces as a failed ok-assertion instead of a silent production NPE. Pyramid 876->877 (testServer +1). Green on the shared server harness.
… (suite hang) + TASK-52 The full testServer tier deterministically hangs at this method (~44th class): its dim info -1/1 probes force a Nether/End load on the long-lived shared AbstractHeadlessServerTest server, which deadlocks after ~43 prior classes. Passes 2/2 in isolation; not a wrap-policy / PR-23 regression (perDimWorldInfo tests run after it and never executed in the hung run; all 44 prior classes pass). @ignore unblocks the tier; the wrapper-isolation half of the contract stays green in the sibling overworldAndVanillaDimsAreNotWrapped. Root cause (harness deadlock) tracked in TASK-52.
…them These were accidentally added by a git add -A in the previous commit — they are generated by in-tree testServer runs (WeightEngine seeds config/advRocketry/ weights.json; logs/ is the run log dir), not source. Neither is tracked on 1.12.
StannisMod
added a commit
that referenced
this pull request
Jun 15, 2026
Updates the planet-weather feature branch to current 1.12 (per-dim WorldInfo wrapper, perDimWorldInfo master switch, weight/wear). Only conflict was the bug-ledger doc: feature/better_weather had independently used ledger #8 for the canDoRainSnowIce density-scale fix, which collided with 1.12 #8 (weight-rework); renumbered chronologically to #15, matching the postponed<->1.12 convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes two rocket subsystems on top of
1.12:1. Rocket weight system + thrust-to-weight launch gate
WeightEnginerewritten with a resolution chain: individual block → byRegex → AR component specifics → Material table (×weightMaterialScale) → fallback.weights.jsongainsmaterials/byRegex/fluids/fallbacksections plus an auto-seed template.StatsRocket:getThrustToWeightRatio(),canLaunch(),getDryAcceleration(); acceleration getters guard against weight ≤ 0 (fixes a div-by-zero →NaN/Infinity, bug ledger Many bugfixes, so many that I can not even list them all + terraforming update #1 #8).minLaunchTWR(config, default 1.05) instead of weight ≥ thrust, combined with the existingerror.rocket.tooHeavyhard-stop.hasEnoughFuelintegrates average acceleration over the burn.weightMaterialScale,fuelMassScale,minLaunchTWR,advancedWeightSystem(Inventories).2. Maintenance-station / parts-wear rework (TASK-45)
1 − wearThrustPenaltyMax · stage/maxStage).IPartWear+CapabilityWear(mirrorsCapabilitySpaceArmor).TileWearablebase (TE-only, no meta overload / no render break); seats wear at 0.25× rate.wearCriticalBlocksLaunch(block vs warn).EmbeddedInventory, 6 slots, backward-compatible NBT). Repairs a worn motor from itsPrecisionAssemblerrepair-recipe ingredients ×serviceStationStandaloneRepairMultiplier(3.0) when no assembler is nearby; assembler path stays ×1.ITEM_HANDLERcapability (hoppers/pipes).partsWearSystem,wearThrustPenaltyMax,wearTankLeakChanceMax,wearTankLeakFuelLoss,wearSeatBlockStageFraction,wearWarnProbability,wearCriticalBlocksLaunch.Tests
testUnit+testIntegration: green.testServer: targeted classes 16/16 —WearSystemTest(6),ServiceStationFullRepairCycleTest(1, assembler-path regression),RocketAssemblySmokeTest(9); plusStatsRocketTest,WeightEngineUnitTest,WeightSystemTest.Known follow-ups (not in this PR)
runClient.WearSystemTest.