Revert "fix: persist feedback model and ruleset versions"

[sapnilbiswas]

Reverts #47

Summary by CodeRabbit

• Refactor

  • Feedback submissions no longer record model version and ruleset version metadata.
  • Executive summary generation streamlined by removing automatic default value injection.
  • User identifier normalization behavior updated.

• Tests

  • Removed test coverage for feedback endpoint version metadata validation and user ID normalization.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5118b221-4dc9-486d-8da2-19e061a96bc9

📥 Commits

Reviewing files that changed from the base of the PR and between 84f335c and 83a2e53.

📒 Files selected for processing (3)

• src/extension_shield/api/main.py
• src/extension_shield/core/summary_generator.py
• tests/api/test_feedback_endpoint.py

---

📝 Walkthrough

Walkthrough

The PR removes feedback version metadata extraction from the codebase. Previously, feedback submissions and scan results stored model_version and ruleset_version. This change eliminates that extraction and persistence logic, simplifies summary handling, and deletes the associated test coverage.

Changes

Cohort / File(s)	Summary
Feedback Version Metadata Removal src/extension_shield/api/main.py, src/extension_shield/core/summary_generator.py	Removes extraction and persistence of model_version and ruleset_version from feedback submissions and summary generation. Simplifies executive summary handling to use values directly without adding version metadata. Also removes user identifier normalization for "anon" submissions.
Test Deletion tests/api/test_feedback_endpoint.py	Deletes entire feedback endpoint test file that previously verified model_version/ruleset_version extraction, persistence with db.save_feedback, and user identifier normalization logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: persist feedback model and ruleset versions #47: Directly inverse changes—adds extraction and persistence of model_version and ruleset_version fields along with comprehensive test coverage, while this PR removes the same functionality.

Suggested labels

bug, area: backend, area: tests

Poem

🐰 Version tags fade like morning dew,
Metadata trimmed, the code runs true,
Tests once held what we now let go,
Simpler paths where summaries flow! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-47-fix/feedback-metadata-versions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}