Skip to content

fix(collector): keep existing device type#42

Merged
Starosdev merged 1 commit into
developfrom
fix/upstream-pr-803-keep-device-type
Dec 1, 2025
Merged

fix(collector): keep existing device type#42
Starosdev merged 1 commit into
developfrom
fix/upstream-pr-803-keep-device-type

Conversation

@Starosdev

Copy link
Copy Markdown
Owner

Summary

Prevents device type from being overwritten during SMART info collection. This preserves user-configured device types for drives that require specific type settings (e.g., USB bridges, RAID controllers).

Origin

Changes

  • Removes the line that overwrites device.DeviceType in SmartCtlInfo()
  • Preserves user-configured device types from collector.yaml

Test Plan

  • Verify drives with custom device types retain their configuration after collector runs
  • Verify normal drives still work correctly

@Starosdev Starosdev added this to the v1.1.0 - Bug Fixes milestone Nov 30, 2025
@Starosdev Starosdev added bug Something isn't working upstream-pr Upstream PR to merge labels Nov 30, 2025
@Starosdev Starosdev self-assigned this Nov 30, 2025
@Starosdev Starosdev added bug Something isn't working upstream-pr Upstream PR to merge labels Nov 30, 2025
Prevents device type from being overwritten during SMART info collection.
This preserves user-configured device types for drives that require
specific type settings (e.g., USB bridges, RAID controllers).
@Starosdev
Starosdev force-pushed the fix/upstream-pr-803-keep-device-type branch from d809cc2 to b5bb1a2 Compare November 30, 2025 06:42
@Starosdev Starosdev changed the title fix(collector): keep existing device type (upstream PR #803) fix(collector): keep existing device type Nov 30, 2025
@Starosdev
Starosdev merged commit e21cac9 into develop Dec 1, 2025
11 of 13 checks passed
@Starosdev
Starosdev deleted the fix/upstream-pr-803-keep-device-type branch January 19, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working upstream-pr Upstream PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant