fix(collector): ignore bit 6 in smartctl exit-code during detect#43
Merged
Merged
Conversation
Smartctl exit code bit 6 indicates "Device error log contains records of errors" which is informational and doesn't mean the device info retrieval failed. This fix ignores bit 6 (masking with 0xBF) to prevent false failures during device detection when drives have historical errors logged.
Starosdev
force-pushed
the
fix/upstream-pr-794-ignore-bit6-exitcode
branch
from
November 30, 2025 06:42
88119e1 to
735fe2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Smartctl exit code bit 6 indicates "Device error log contains records of errors" which is informational and doesn't mean the device info retrieval failed. This fix ignores bit 6 (masking with 0xBF) to prevent false failures during device detection when drives have historical errors logged.
Origin
Changes
SmartCtlInfo()to mask bit 6Test Plan