Fix dropdown menu backgrounds and settings popup theme matching#570
Fix dropdown menu backgrounds and settings popup theme matching#570WyattGorman wants to merge 5 commits into
Conversation
…alog - Inject active application theme (`treo-theme-dark` / `treo-theme-light`) into Angular Material dialog components dynamically when opening the dashboard, detail, and mobile settings dialogs. - Apply `panelClass="theme-select-panel"` to all `mat-select` elements across settings templates. - Explicitly style backgrounds and option text colors for settings overlays depending on the active theme in `styles.scss` to prevent transparent overlay readability issues. Co-authored-by: WyattGorman <444043+WyattGorman@users.noreply.github.com>
…alog - Inject active application theme (`treo-theme-dark` / `treo-theme-light`) into Angular Material dialog components dynamically when opening the dashboard, detail, and mobile settings dialogs. - Apply `panelClass="theme-select-panel"` to all `mat-select` elements across settings templates. - Explicitly style backgrounds and option text colors for settings overlays depending on the active theme in `styles.scss` to prevent transparent overlay readability issues. Co-authored-by: WyattGorman <444043+WyattGorman@users.noreply.github.com>
- Inject active application theme (`treo-theme-dark` / `treo-theme-light`) into Angular Material dialog components dynamically when opening the dashboard, detail, and mobile settings dialogs. - Apply `panelClass="theme-select-panel"` to all `mat-select` elements across settings templates. - Explicitly style backgrounds and option text colors for settings overlays depending on the active theme in `styles.scss` to prevent transparent overlay readability issues. - Apply dark and light backgrounds respectively to dashboard `mat-menu` components ensuring readable text. Co-authored-by: WyattGorman <444043+WyattGorman@users.noreply.github.com>
- Pass current theme class dynamically to mat-dialog instances via panelClass. - Add theme-select-panel class to mat-select components for explicit styling. - Update styles.scss to provide solid backgrounds for mat-select and mat-menu. - Fix dark mode text readability in dialogs by targeting the cdk-overlay-container and settings-dialog-panel. Co-authored-by: WyattGorman <444043+WyattGorman@users.noreply.github.com>
…443338120339780 Fixes dropdown backgrounds being transparent, and adds theme overlay support to the settings window
|
Thanks for the contribution @WyattGorman — the dialog theming fix is exactly the right approach. A few things to address before we can merge: 1. Target Please retarget this PR to the 2. Drop the The dropdown panel background is already handled globally in ```scss These cascade to the CDK overlay and Angular Material reads them directly — no 3. Remove the redundant mat-menu SCSS Same reason — 4. Fix a dead CSS selector ```scss
What to keep: The |
Starosdev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. This still needs changes before it can merge.
Blocking items:
-
Please retarget this PR from
mastertodevelop, then rebase on the latestdevelop. The PR is currently reported as conflicting, and the same conflicts reproduce locally in the settings templates plus dashboard/mobile settings TypeScript files. -
Please remove the
panelClass="theme-select-panel"additions from the settings templates and remove the related.theme-select-panelSCSS. Currentdevelopalready sets the Material overlay background colors globally with CSS variables, so the per-select panel class is redundant. -
Please remove the redundant
.mat-mdc-menu-panel/.mat-mdc-menu-itemdark-mode SCSS additions. The menu container background is already handled globally. -
Please remove the dead selector
.treo-theme-dark.mat-mdc-dialog-container .mdc-dialog__surface; those classes are not on the same element, so that selector does not match. Keep the dialogpanelClassapproach for the settings dialogs and the valid overlay-container styling.
Once this is rebased onto develop and narrowed to the dialog theming fix, I can review again.
Summary
Adds a theme-matched background color to the dropdown menus, and adds theme matched colored text and backgrounds to the settings popup window.
Type of Change
Related Issues
N/A
Changes Made
-Adds a theme-matched background color to the dropdown menus
Testing
Tested in my local environment
Checklist
Screenshots (if applicable)