Conform package to registry conventions and rework credential flow - #1
Merged
Merged
Conversation
- replace seeded-password + get-credentials anti-pattern with the canonical setupOnInit watcher (critical task) + set-admin-password action; password applied via manage.py in a temp subcontainer, covers first-set and reset - bump start-sdk 1.5.0 -> 1.5.3; rename version file to current.ts (2.20.15:0) - remove dead upstream-project submodule and stray gitlink; replace symlinked icon/LICENSE with real files (white-on-green leaf, GPL-3.0) - match hello-world boilerplate exactly (s9pk.mk, .gitignore, AGENTS, CLAUDE); add workflows (main branch), UPDATING, TODO, assets/ - point packageRepo at Start9-Community; sync README/instructions with the actual UX (no user-reachable consume folder; web/mail/API ingestion) Verified on StartOS 0.4.0-beta.9: install, health, task lifecycle, login, rotation, and pre-init guard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MattDHill
approved these changes
Jun 11, 2026
Member
Author
|
Thanks for the review and merge, @MattDHill! 🎉 Registry conformance + the reworked credential flow are now on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full audit pass to ready this package for the community registry, verified end-to-end on a StartOS 0.4.0-beta.9 box.
Credential flow (the big one)
get-admin-credentialsanti-pattern with the canonical shape from the packaging guide's admin-credentials recipe: asetupOnInitwatcher surfaces a critical task until a password is stored, and a Set Admin Password action generates the password, applies it viamanage.pyin a temporary subcontainer (get_or_create+set_password, run as thepaperlessuser like the image's own init scripts), stores it, and returns it. The same action covers first-set and rotation; upstream's env-basedmanage_superuserpath is unused (verified create-only — it can never rotate).main.tsreads onlysecretKeyfrom the store, so setting/rotating the password does not restart the service.Soundness fixes
icon.svgandLICENSEwere symlinks into a never-checked-out submodule (broken in any bare clone); replaced with real files — white-on-green leaf derived from the upstream logo, GPL-3.0 text matching the manifest. Removed.gitmodulesand two stray gitlinks (upstream-project,ai-service-packaging) plus the corrupted.gitignoreline they caused.Conventions
utils.getDefaultString; version file renamed tocurrent.tsat2.20.15:0.main); UPDATING.md, TODO.md, assets/ added;packageRepo→ Start9-Community.Verified on hardware
Install → health green → critical task present → action → task clears → real login (HTTP 200, DRF token) through the TLS vhost → rotate → old password rejected (400), new accepted (200). Fresh-reinstall pass exercised the pre-init guard and the full first-run order on a virgin database.
🤖 Generated with Claude Code