Conversation
The container runtime tags every effect call with the calling procedure's event id under `eventId`, overwriting any `eventId` the call itself named. effects.action.run now names the event id its form was opened under (#4062), so a service's run reached StartOS with its own procedure's id, or none, and the target refused it: "getActionInput has not been called for EventID …". Seen on a VM running #4062's build: Tor's form opened under E4VNHKM6…, and the run executed under a fresh SVS5F3TC…. An `eventId` the effect names now wins over the tag. Nothing in StartOS reads the tag. Helix-Harness: claude-code Helix-Model: claude-opus-5-5
Member
Author
|
Superseded, per dr-bonez's review in Matrix. The runtime already tags every effect call with the calling procedure's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The container runtime lets an effect call's own
eventIdthrough.rpcRoundForbuilds each effect request's params as{ ...params, eventId: <calling procedure's id> }, which overwrote theeventIdthateffects.action.runnow carries. The params are built by a neweffectParams, where a caller-namedeventIdwins over the tag.Why
#4062 runs a service's action under the
eventIdits form was opened with, so the target'sAction.runfinds that form. On a VM running #4062's build (CI run 35900355405,b3da16d), Bitcoin opened Tor's Add Onion Service form and ran it. Tor's runtime log shows the two calls under different ids:Bitcoin's bundled SDK and
EffectCreator.runboth passedeventId: E4VNHKM6….rpcRoundForthen replaced it with Bitcoin's own procedure id, which is null during init, so the field arrived empty andrun_actionfell back to a freshGuid. #4062's unit test mocked the effects below this layer, which is why it passed.Nothing in StartOS reads the tag.
event_idappears inshared-libs/crates/start-core/src/service/effects/only onRunActionParamsand onprelude.rs'sEventIdstruct, which nothing uses. So letting a namedeventIdthrough changes no other effect.Verification
EffectCreator.test.ts: the tag is added, a namedeventIdsurvives, and no id is sent outside a procedure.npm run checkandnpm test(4 suites, 16 tests) pass in container-runtime, and prettier 3.8.3 passes.