Tabulator #182
Tabulator #182
Conversation
# Conflicts: # src/Lib/StatCan.OrchardCore.Application.Targets/StatCan.OrchardCore.Application.Targets.csproj
M-A-Boucher
left a comment
M-A-Boucher
left a comment
There was a problem hiding this comment.
I think there are still files from the Assessment branch in this branch.
src/Modules/StatCan.OrchardCore.Assessment/Views/Widget-Assessment.liquid
Outdated
Show resolved
Hide resolved
| <ProjectReference Include="..\StatCan.OrchardCore.Security\StatCan.OrchardCore.Security.csproj" PrivateAssets="none" /> | ||
|
|
||
| <!-- Modules --> | ||
| <ProjectReference Include="..\..\Modules\StatCan.OrchardCore.Assessment\StatCan.OrchardCore.Assessment.csproj" PrivateAssets="none" /> |
There was a problem hiding this comment.
This line of code is from another branch and can be removed.
| @@ -7,7 +7,10 @@ | |||
|
|
|||
There was a problem hiding this comment.
Layout.liquid can be deleted. These are base templates for a theme and they're not needed for a module.
src/Lib/StatCan.OrchardCore.Application.Targets/StatCan.OrchardCore.Application.Targets.csproj
Outdated
Show resolved
Hide resolved
| "DisplayName": "TableCreator", | ||
| "Settings": { | ||
| "ContentTypeSettings": { | ||
| "Creatable": true, |
There was a problem hiding this comment.
Widgets usually have the following settings set to false: Creatable, Listable, Draftable, Versionable, Securable. Simply change them to false.
|
|
||
| public int Create() | ||
| { | ||
| return 1; |
There was a problem hiding this comment.
Is this required ? It is not doing anything
jptissot
added
the
wait-to-merge
|
I edited the initial post to link the issue. Let's review the issue and see what we can come up with as to requirements for the issue. |
3 participants
Fix #177