Remove dead template code and fix compiler warnings in CodeFixes project - #45
Merged
Merged
Conversation
Co-Authored-By: Stefan Ossendorf <stefan@familie-ossendorf.de>
Co-Authored-By: Stefan Ossendorf <stefan@familie-ossendorf.de>
Co-Authored-By: Stefan Ossendorf <stefan@familie-ossendorf.de>
Co-Authored-By: Stefan Ossendorf <stefan@familie-ossendorf.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MakeUppercaseAsyncmethod (leftover VS code-fix template boilerplate) — eliminates CS0618 and CS8604root,diagnosticSpan, anddeclarationvariables that were only used to feedMakeUppercaseAsyncasyncfromRegisterCodeFixesAsync(no awaits remain); returnsTask.CompletedTaskusingdirectives (CSharp.Syntax,Rename)Test plan
dotnet build src/Csla.DataPortalExtensionGenerator.Analyzers.CodeFixes/— 0 warnings, 0 errorsdotnet build— full solution clean (pre-existing Demo DPEGEN1002 warnings unaffected)dotnet test— all 123 tests pass