Skip to content

Added spotbugs and fixed bugs found by spotbugs #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StefanRichterHuber merged 1 commit into from
Mar 2, 2026
Merged

Added spotbugs and fixed bugs found by spotbugs #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@ jobs:
cache: maven
- name: Install target wasm32-wasip1
run: rustup target add wasm32-wasip1
- name: Install wasm-opt
run: cargo install wasm-opt
- name: Build with Maven
run: mvn -B package --file pom.xml
run: mvn -P spotbugs,wasm-opt -B package --file pom.xml

# 2. Parse the report and comment on the PR
# Parse the test coverage report and comment on the PR
- name: JaCoCo Report to PR
id: jacoco
uses: madrapps/jacoco-report@v1.7.1
Expand Down
34 changes: 34 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,5 +353,39 @@
</plugins>
</build>
</profile>

<!-- Optional (because it takes very long) invocation of spotbugs to scan for security
issues-->
<profile>
<id>spotbugs</id>
<build>
<plugins>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>4.9.8.2</version>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration>
<excludeFilterFile>spotbugs-ignore.xml</excludeFilterFile>
<maxHeap>2048</maxHeap>
<plugins>
<plugin>
<groupId>com.h3xstream.findsecbugs</groupId>
<artifactId>findsecbugs-plugin</artifactId>
<version>1.14.0</version>
</plugin>
</plugins>
</configuration>
</plugin>

</plugins>
</build>
</profile>
</profiles>
</project>
5 changes: 5 additions & 0 deletions spotbugs-ignore.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<FindBugsFilter>
<Match>
<Class name="~.*WasmLib.*" />
</Match>
</FindBugsFilter>
2 changes: 1 addition & 1 deletion src/main/java/io/github/stefanrichterhuber/quickjswasmjava/QuickJSPromise.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* CompletableFuture to provide a Java
* interface to the promise.
*/
class QuickJSPromise extends CompletableFuture<Object> {
final class QuickJSPromise extends CompletableFuture<Object> {
private static final Logger LOGGER = LogManager.getLogger();

private long promisePtr;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/github/stefanrichterhuber/quickjswasmjava/ScriptInvocationHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* Invocation handler for a QuickJS context. This allows to create a dynamic
* proxy for the QuickJS context / a QuickJS object.
*/
class ScriptInvocationHandler<K, V> implements InvocationHandler {
final class ScriptInvocationHandler<K, V> implements InvocationHandler {

/**
* The QuickJS context to use.
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/log4j2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</Console>
</Appenders>
<Loggers>
<Root level="debug">
<Root level="info">
<AppenderRef ref="Console" />
</Root>
</Loggers>
Expand Down