fix(escrow): require configuration before deposits - #217
Open
prissca wants to merge 1 commit into
Open
Conversation
|
@prissca is attempting to deploy a commit to the Deejah Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #204
Summary
escrow_not_configuredwhen a deposit targets an unconfigured queueget_configuse the same explicit unconfigured behavior instead of returning a misleading sentinel adminVerification
cargo fmt --all -- --checkgit diff --checkcargo test -p lineproof-escrowis left to CI because this Windows host has the Rust MSVC target but nolink.exeDesign note
This keeps configuration queue-scoped. A contract-wide default admin would create a second source of authority that must be migrated and governed; requiring an explicit queue configuration makes the trust boundary visible and prevents accidental deployment in an implicit self-admin state.