Skip to content

fix(escrow): require configuration before deposits - #217

Open
prissca wants to merge 1 commit into
Stellar-Deejah:mainfrom
prissca:issue-204-require-escrow-config
Open

fix(escrow): require configuration before deposits#217
prissca wants to merge 1 commit into
Stellar-Deejah:mainfrom
prissca:issue-204-require-escrow-config

Conversation

@prissca

@prissca prissca commented Aug 21, 2026

Copy link
Copy Markdown

Closes #204

Summary

  • fail closed with escrow_not_configured when a deposit targets an unconfigured queue
  • make get_config use the same explicit unconfigured behavior instead of returning a misleading sentinel admin
  • add regression coverage for the depositor-as-admin attack setup and unconfigured reads

Verification

  • cargo fmt --all -- --check
  • git diff --check
  • full cargo test -p lineproof-escrow is left to CI because this Windows host has the Rust MSVC target but no link.exe

Design note

This keeps configuration queue-scoped. A contract-wide default admin would create a second source of authority that must be migrated and governed; requiring an explicit queue configuration makes the trust boundary visible and prevents accidental deployment in an implicit self-admin state.

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

@prissca is attempting to deploy a commit to the Deejah Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contracts: EscrowConfig deposit function silently becomes self-administered when no config exists — any depositor becomes escrow admin

1 participant