fix: cancel in-flight DashboardPage lookups with AbortController (Fixes #203) - #218
Open
waterWang wants to merge 1 commit into
Open
fix: cancel in-flight DashboardPage lookups with AbortController (Fixes #203)#218waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
- Abort the previous fetch when the user triggers a new lookup so stale responses can't overwrite newer results - Reuse the controller's signal for the escrow enrichment fetches - Guard state updates with signal.aborted (covers unmount + re-lookup races) - Wrap lookup in useCallback to enable stable memoization Fixes Stellar-Deejah#203
|
@waterWang is attempting to deploy a commit to the Deejah Team on Vercel. A member of the Team first needs to authorize it. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #203 —
DashboardPage.lookup()never cancelled in-flight fetches, so rapid re-lookups ran concurrent requests and the last-resolving (potentially stale) response won. It also had no guard against state updates after unmount.Changes
signalis passed to both the enrollments fetch and the escrow-enrichment fetches insidePromise.all, so cancellation covers the whole lookup pipelinesignal.abortedis checked before setting records/loading in thecatch/finallyblocks — this covers both the re-lookup race and the unmount race (an unmount cleanup effect aborts the controller)useCallback:lookupis now memoized withpublicKeyas its dependency, enabling correct memoization if passed to child componentsVerification
npx tsc --noEmit— cleannpx vitest run— 40/40 tests pass, including the existing DashboardPage accessibility/error-announcement test