Skip to content

feat(ci): add CODEOWNERS and secret scanning - #227

Open
Jokay1997 wants to merge 4 commits into
Stellar-Deejah:mainfrom
Jokay1997:feat/186-CODEOWNERS-secret-scanning
Open

feat(ci): add CODEOWNERS and secret scanning#227
Jokay1997 wants to merge 4 commits into
Stellar-Deejah:mainfrom
Jokay1997:feat/186-CODEOWNERS-secret-scanning

Conversation

@Jokay1997

Copy link
Copy Markdown

Summary

This PR adds a CODEOWNERS file for automatic reviewer assignment and TruffleHog secret scanning to prevent accidentally committed secrets.

Changes

.github/CODEOWNERS

.github/workflows/security-scan.yml

  • Added secret-scan job using TruffleHog
  • Runs on push to main and on all PRs
  • Uses --only-verified\ flag to reduce false positives
  • Configured with \ etch-depth: 0\ for full history scanning

CONTRIBUTING.md

  • Documented branch protection rules (required status checks, required reviewers, no force-push)
  • Documented CODEOWNERS file paths and owners
  • Documented secret scanning behavior

Acceptance Criteria

  • .github/CODEOWNERS\ created with owners for critical paths
  • Secret scanning step added to \security-scan.yml\
  • Secret scanning runs on push to main and on PRs
  • \CONTRIBUTING.md\ documents required branch protection rules
  • \CONTRIBUTING.md\ documents required reviewer process via CODEOWNERS

Closes #186

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

@KarenZita01 is attempting to deploy a commit to the Deejah Team on Vercel.

A member of the Team first needs to authorize it.

@Jokay1997
Jokay1997 force-pushed the feat/186-CODEOWNERS-secret-scanning branch 5 times, most recently from f76b112 to 0fa6bae Compare August 28, 2026 12:38
…and Rust errors

- Add .github/CODEOWNERS for auto-reviewer assignment
- Add TruffleHog secret scanning step to security-scan.yml
- Update CONTRIBUTING.md with branch protection rules
- Fix anchore/scan-action param: output -> output-file
- Replace deprecated .deploy() with .deploy_v2()
- Remove unused ESCROW_TTL_BUFFER constant
- Add default-features=false to soroban-sdk to fix wasm duplicate lang item
@Jokay1997
Jokay1997 force-pushed the feat/186-CODEOWNERS-secret-scanning branch from 57a8176 to ec7ec10 Compare August 31, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: No CODEOWNERS file and no secret scanning — PRs have no auto-reviewers and secrets can be committed silently

2 participants