feat(escrow): validate config bounds and reject unconfigured deposits (Closes #179) - #244
Merged
k-deejah merged 1 commit intoSep 3, 2026
Conversation
|
@stayzappy is attempting to deploy a commit to the Deejah Team on Vercel. A member of the Team first needs to authorize it. |
stayzappy
force-pushed
the
fix/issue-179-escrow-config-validation
branch
from
August 31, 2026 17:42
7417108 to
84ab92c
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179
Summary of Changes (Closes #179)
1. Config Bounds Validation
set_configincontracts/lineproof-escrow/src/lib.rsto enforceconfig.min_deposit <= config.max_deposit(panics with"min_deposit_exceeds_max").config.hold_period_days > 0(panics with"hold_period_must_be_positive").2. Explicit Escrow Initialization Guard
deposit(). Callingdeposit()on an uninitialized queue escrow now explicitly panics with"escrow_not_configured".3. Test Suite
contracts/lineproof-escrow/src/test.rscovering:set_configvalidation ofmin_deposit > max_depositset_configvalidation ofhold_period_days == 0depositrejection when escrow is not configuredVerification
cargo test -p lineproof-escrow: 18 passed, 0 failed.cargo test): 93 passed, 0 failed.