fluid-server: dependency scans (#674) and inner tx signer-weight preflight (#686)#798
Merged
0xVida merged 2 commits intoJun 1, 2026
Conversation
Add CI matrix workflow for cargo-audit and npm audit on fluid-server, with JSON report artifacts and failure on high/critical advisories. Closes Stellar-Fluid#674 Co-authored-by: Cursor <cursoragent@cursor.com>
Validate inner transaction signature weight against the source account med_threshold via Horizon before fee-bumping, with unit and integration tests. Closes Stellar-Fluid#686 Co-authored-by: Cursor <cursoragent@cursor.com>
|
@josephchimebuka Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements two
fluid-serverhardening items:cargo-auditon the Rust crate andnpm auditonfluid-server/wasm-demo, uploads JSON reports as artifacts, and fails builds on high/critical findings.med_threshold, returningINSUFFICIENT_SIGNATURE_WEIGHTwhen it does not.Changes
CI / supply chain (#674)
.github/workflows/dependency-audit.yml– PR/push matrix (cargo-audit,npm-audit)fluid-server/audit.toml– cargo-audit config stub for reviewed advisoriesfluid-server/verification/dependency-scans-integration.txt– verification notesResilience (#686)
fluid-server/src/signer_weight.rs– weight calculation + validationfluid-server/src/horizon.rs–fetch_account_authfluid-server/src/main.rs– preflight hook inprocess_fee_bump_requestfluid-server/src/mock_horizon.rs– per-account auth overrides for testsfluid-server/tests/signer_weight_integration.rs– end-to-end/fee-bumpchecksfluid-server/docs/inner-transaction-signer-weight-validation.mdTest plan
From
fluid-server/:Verified locally:
cargo test signer_weight::tests– 4 passedcargo test --test signer_weight_integration– 1 passed (reject insufficient weight + accept sufficient weight)Screenshots / terminal output
Reviewer verification files:
fluid-server/verification/dependency-scans-integration.txtfluid-server/verification/inner-transaction-signer-weight.txtCloses #674
Closes #686
Made with Cursor