Add dedicated cache TTL config for stats/summary - #60
Merged
christabel888 merged 2 commits intoAug 28, 2026
Merged
Conversation
…ar-Insightss#4) CacheConfig gains stats_summary_ttl (env CACHE_STATS_SUMMARY_TTL), defaulting to dashboard_stats_ttl so existing CACHE_DASHBOARD_STATS_TTL customizations carry over unless explicitly overridden. Adds keys::stats_summary() cache key builder and tests covering both the fallback and override paths.
Conflict in src/cache.rs was a trivial comment wording difference, resolved by keeping the grammatically-correct plural. Also fixed a real bug this merge chain exposed: Stellar-Insightss#54 and Stellar-Insightss#58 (both already merged to main) independently numbered their migrations 031 (031_create_network_metrics_timeseries.sql and 031_create_daily_stat_snapshots.sql). sqlx::migrate! requires unique version numbers per migration, so main was left in a broken state. Renumbered the latter to 034_create_daily_stat_snapshots.sql (the next free slot after 032/033) — no code or other migration references the old filename. Verified with cargo check (clean).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
Adds a stats_summary_ttl field to CacheConfig (env CACHE_STATS_SUMMARY_TTL), used by #1's /api/v1/stats/summary handler via cached_query and the new keys::stats_summary() cache key. Defaults to dashboard_stats_ttl (CACHE_DASHBOARD_STATS_TTL) rather than a hardcoded value, so an existing deployment's dashboard TTL customization carries over automatically unless a different freshness window is explicitly requested for the homepage tiles.
Also documents CACHE_STATS_SUMMARY_TTL in .env.example and adds two tests: one confirming the fallback-to-dashboard-ttl behavior, one confirming the override works independently.
Note: #1's endpoint (separate PR) already wires up caching using this same get_ttl("stats_summary")/keys::stats_summary() pattern; this PR formalizes the dedicated TTL config so it isn't just reusing the raw dashboard key by coincidence.