fix(infra): rewrite trivy jq evaluation with null-safe stream handling (#320) - #450
Open
Bilalishaq7 wants to merge 3 commits into
Open
fix(infra): rewrite trivy jq evaluation with null-safe stream handling (#320)#450Bilalishaq7 wants to merge 3 commits into
Bilalishaq7 wants to merge 3 commits into
Conversation
Contributor
Author
|
Gate Verification Successful: |
AbuJulaybeeb
requested changes
Aug 25, 2026
AbuJulaybeeb
left a comment
Contributor
There was a problem hiding this comment.
fix failing ci and update branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the Trivy security scan evaluation in
.github/workflows/ci.ymlto prevent silent no-op failures. The previousjqexpression used stream addition (.Misconfigurations[]? + .Vulnerabilities[]?), which evaluated to an empty stream (0) whenever a scan output omitted the.Misconfigurationskey.The new implementation handles missing keys explicitly using null-safe array merging (
.Vulnerabilities // [],.Misconfigurations // [],.Secrets // []), outputs JSON directly to file to preserveset -o pipefailsemantics, and blocks vulnerable images from publishing to GHCR.Type
Related Issue
Closes #320
Testing
Infra / Docs Sync
docs/*claims were verified against the manifests (deployment, database, indexer, runbooks)Screenshots (if UI change)
N/A (CI/CD Infrastructure Update)