feat(hooks): sortBy, MX check, rounding mode, preset export/import - #710
Open
Inkman007 wants to merge 1 commit into
Open
feat(hooks): sortBy, MX check, rounding mode, preset export/import#710Inkman007 wants to merge 1 commit into
Inkman007 wants to merge 1 commit into
Conversation
…mport - useGroupLeaderboard: add sortBy option (totalPaid/invoiceCount/streak), re-sorts client-side without refetch - useEmailValidation: add checkMx option to gate the async MX record check - useSplitCalculator: add roundingMode option (floor/ceil/nearest) with remainder assigned to first recipient so totals always balance - useFilterPresets: add exportPresets/importPresets for sharing filter presets as JSON Closes Stellar-split#691 Closes Stellar-split#692 Closes Stellar-split#693 Closes Stellar-split#694
|
Someone is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Inkman007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useGroupLeaderboard: addedsortByoption (totalPaid|invoiceCount|streak) that re-sorts entries client-side without a refetch; extendedGroupMemberwith the new metric fields (also updated the leaderboard API route to populate them).useEmailValidation: addedcheckMxoption to gate the existing debounced (500ms) async MX check.useSplitCalculator: addedroundingModeoption (floor|ceil|nearest) with the rounding remainder assigned to the first recipient so shares always sum exactly to the total.useFilterPresets: addedexportPresets()/importPresets(json)for sharing dashboard filter presets, merging by name and validating shape.Closes #691
Closes #692
Closes #693
Closes #694
Validation performed
lint/test/typecheckin this environment —node_modulesis not installed (pre-existing environment issue, unrelated to this change).