Draft conflict detection, rate caching/alerts, collaborator count badge - #712
Open
knytcomics-ui wants to merge 1 commit into
Open
Conversation
- useOfflineDraftAutosave: check server updatedAt on reconnect and call onConflict instead of silently overwriting a newer server draft - useXlmUsdcRate: add alertThreshold/onAlert to notify on large rate moves - useFiatRate: add configurable ttl and isStale to avoid using overly stale cached rates - CollaborationCursors: show an "N online" badge in the top-right corner Closes: Stellar-split#684 Closes: Stellar-split#683 Closes: Stellar-split#682 Closes: Stellar-split#673
|
Someone is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@knytcomics-ui Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useOfflineDraftAutosave: checks the server draft'supdatedAton reconnect before syncing and calls a newonConflictcallback instead of silently overwriting a newer server version.useXlmUsdcRate: adds analertThreshold/onAlertoption that fires when the rate moves more than the threshold percentage from the rate at hook initialization (at most once per polling interval).useFiatRate: adds a configurablettloption (default 60s) and returnsisStalewhen the cached rate has exceeded it.CollaborationCursors: adds an "N online" badge in the top-right corner, hidden when no collaborators are present.Validation performed
npm cifails on a pre-existing broken dependency inpackage.json(@typescript-eslint/plugin@^6.21.0, unrelated to this change), sonode_modulesisn't installed here.Closes #684
Closes #683
Closes #682
Closes #673