fix: exponential backoff retry, masked amounts, session dismiss banner - #714
Open
rejoicetukura-blip wants to merge 1 commit into
Open
Conversation
- useTransactionWithRetry: exponential backoff (1s base, 30s cap), configurable maxRetries (default 5), expose attemptCount - ConfidentialPaymentFlow: mask amounts by default with a show/hide toggle - UpgradeBanner: dismiss via sessionStorage flag so it reappears next session - DashboardClient already syncs filters to URL search params; no change needed Closes Stellar-split#679 Closes Stellar-split#669 Closes Stellar-split#668 Closes Stellar-split#667
|
Someone is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@rejoicetukura-blip Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useTransactionWithRetry: replaced fixed delay with exponential backoff (1s base, doubling, capped at 30s), mademaxRetriesconfigurable (default 5), and exposed the current retryattemptCountin the hook's return value.ConfidentialPaymentFlow: amounts are masked (****, via password-type input) by default, with a "Show amounts" / "Hide amounts" toggle; state is not persisted and resets to masked on each mount.UpgradeBanner: dismiss now uses asplit_upgrade_dismissedflag insessionStorage(instead of per-versionlocalStorage), so the banner stays hidden for the rest of the session and reappears next session.DashboardClient: already syncs filters to URL search params (preset/status/sort/date range/tag viauseSearchParams/useRouter) — no changes needed for DashboardClient: Sync active filters to URL search parameters #668.Closes #679
Closes #669
Closes #668
Closes #667
Validation performed
npx tsc --noEmit— no type errors in the changed files.useTransactionWithRetry.test.ts,ConfidentialPaymentFlow.test.tsx) against the changes; no breaking assumptions (tests assert formulas independently of hook defaults, and assertinput.valuewhich is unaffected by thepasswordinput type).npm test/lintsuite:npm cifails on this checkout due to a pre-existing, unrelated bad dependency name inpackage.json(@typescript-eslint/plugin@^6.21.0, which doesn't exist on the registry — likely meant@typescript-eslint/eslint-plugin). This is a pre-existing repo issue, not introduced by this change, and was left untouched per scope.