Fix toast positioning, address validation, proof zoom/pan, and locale persistence - #717
Open
Oryke wants to merge 1 commit into
Open
Fix toast positioning, address validation, proof zoom/pan, and locale persistence#717Oryke wants to merge 1 commit into
Oryke wants to merge 1 commit into
Conversation
…persistence Closes Stellar-split#676 Closes Stellar-split#675 Closes Stellar-split#662 Closes Stellar-split#661
|
@Oryke is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Oryke Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToastContainer: added apositionprop (top-right|top-left|bottom-right|bottom-left), defaulting totop-right.AddressChangeRequestModal: wired the new-address field touseAddressValidation, showing an inline error and disabling submit while the address is invalid/empty; validates on blur and on change after the first submit attempt.ProofViewer: added zoom (+/-, 50%-400%), drag-to-pan, and reset controls for the verified proof image.LanguageSwitcher: persists the selected locale tolocalStorageundersplit_app_localeand re-applies it on mount.Closes #676
Closes #675
Closes #662
Closes #661
Validation performed
npm ci/next lint/tsccould not run in this environment:package.jsonhas a pre-existing invalid dependency (@typescript-eslint/plugin, likely meant to be@typescript-eslint/eslint-plugin) that 404s on install, unrelated to this change.