Reminder snooze, webhook test ping, and XLM/USDC precision fix - #718
Open
studiomonkeyx wants to merge 1 commit into
Open
Reminder snooze, webhook test ping, and XLM/USDC precision fix#718studiomonkeyx wants to merge 1 commit into
studiomonkeyx wants to merge 1 commit into
Conversation
- ReminderChecker: surface due reminders with a Snooze dropdown (1h/24h/3d) backed by expirySnooze persistence - expirySnooze: add 24h and 3d snooze options - WebhookConfig: add "Send Test Ping" button that POSTs a test payload and shows the response status/body inline - AmountDenominationInput: format converted amounts to 7 decimals for XLM and 2 decimals for USDC Closes Stellar-split#659 Closes Stellar-split#660 Closes Stellar-split#655 TransferOwnershipModal (Stellar-split#664) already satisfies its acceptance criteria (double-entry address confirmation with disabled submit until match) per existing tests in src/__tests__/TransferOwnershipModal.test.tsx; no change needed. Closes Stellar-split#664
|
@studiomonkeyx is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@studiomonkeyx Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReminderChecker: shows due reminders with a Snooze dropdown (1 hour / 24 hours / 3 days), persisted viaexpirySnooze; the reminder reappears once the snooze expires on the next 60s check cycle.expirySnooze: extendedSnoozeOptionwith24hand3ddurations (existing1h/4h/until-tomorrowoptions untouched).WebhookConfig: added a "Send Test Ping" button that POSTs{"event":"test"}directly to the configured URL and displays the response status code and first 200 chars of the body inline.AmountDenominationInput: fixed converted-amount formatting to use 7 decimal places for XLM and 2 for USDC (previously both used 4, and the toggle stripped trailing zeros inconsistently).TransferOwnershipModal(TransferOwnershipModal: Add two-step confirmation requiring address retype #664): reviewed against its acceptance criteria — double-entry address retype, submit disabled until exact match, irreversibility warning — all already satisfied and covered bysrc/__tests__/TransferOwnershipModal.test.tsx. No code change was needed.Closes #659
Closes #660
Closes #655
Closes #664
Validation performed
npm cifails on a pre-existing, unrelated dependency resolution error (@typescript-eslint/plugin@^6.21.0returns 404 from the registry), sonode_modulescould not be installed. This is a pre-existing repository issue, not introduced by this change.