docs: add test plans for issues #670-673, fix broken stats.rs - #713
Merged
Kingsman-99 merged 1 commit intoAug 30, 2026
Merged
Conversation
…ts.rs Adds boundary/scenario test plans for FeeBracket selection, ContributionResult capping, InstalmentPlan paid_index tracking, and get_stats zero-state, mapping each acceptance criterion to exact code locations and expected values. Also deduplicates contracts/split/src/stats.rs, which had two competing get_stats/Stats implementations pasted together from an unresolved merge across two PRs for issue Stellar-split#313. The module isn't wired into the crate (no `mod stats;` in lib.rs), so this never surfaced as a compile error, but it was invalid Rust regardless. Co-
|
@SYMBAxx Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds boundary/scenario test plans for FeeBracket selection, ContributionResult capping, InstalmentPlan paid_index tracking, and get_stats zero-state, mapping each acceptance criterion to exact code locations and expected values.
Also deduplicates contracts/split/src/stats.rs, which had two competing get_stats/Stats implementations pasted together from an unresolved merge across two PRs for issue #313. The module isn't wired into the crate (no
mod stats;in lib.rs), so this never surfaced as a compile error, but it was invalid Rust regardless.closes #670
closes #671
closes #672
closes #673
Co-